Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: diversify currencies of examples #943

Merged
merged 2 commits into from
Mar 17, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -345,20 +345,19 @@ <h3>
displayItems: [
{
label: "Sub-total",
amount: { currency: "USD", value: "55.00" },
amount: { currency: "GBP", value: "55.00" },
},
{
label: "Sales Tax",
amount: { currency: "USD", value: "5.00" },
type: "tax"
label: "Value-Added Tax (VAT)",
amount: { currency: "GBP", value: "5.00" },
},
],
total: {
label: "Total due",
// The total is USD$65.00 here because we need to
// The total is GBP£65.00 here because we need to
// add shipping (below). The selected shipping
// costs USD$5.00.
amount: { currency: "USD", value: "65.00" },
// costs GBP$5.00.
marcoscaceres marked this conversation as resolved.
Show resolved Hide resolved
amount: { currency: "GBP", value: "65.00" },
},
};
</pre>
Expand All @@ -375,14 +374,16 @@ <h3>
const shippingOptions = [
{
id: "standard",
label: "🚛 Ground Shipping (2 days)",
amount: { currency: "USD", value: "5.00" },
// Shipping by truck, 2 days
label: "🚛 Envío por camión (2 dias)",
amount: { currency: "EUR", value: "5.00" },
selected: true,
},
{
id: "drone",
label: "🚀 Drone Express (2 hours)",
amount: { currency: "USD", value: "25.00" }
// Drone shipping, 2 hours
label: "🚀 Drone Express (2 horas)",
amount: { currency: "EUR", value: "25.00" }
},
];
Object.assign(details, { shippingOptions });
Expand All @@ -401,7 +402,7 @@ <h3>
// Certain cards incur a $3.00 processing fee.
const cardFee = {
label: "Card processing fee",
amount: { currency: "USD", value: "3.00" },
amount: { currency: "AUD", value: "3.00" },
};

// Modifiers apply when the user chooses to pay with
Expand All @@ -412,7 +413,7 @@ <h3>
supportedMethods: "basic-card",
total: {
label: "Total due",
amount: { currency: "USD", value: "68.00" },
amount: { currency: "AUD", value: "68.00" },
},
data: {
supportedNetworks: networks,
Expand Down Expand Up @@ -1726,10 +1727,10 @@ <h2>
A <a>valid decimal monetary value</a> containing a monetary amount.
</dd>
</dl>
<pre class="example js" title="How to represent US$55.00">
<pre class="example js" title="How to represent 5000 Japanese Yen">
{
"currency": "USD",
"value": "55.00"
"currency": "JPY",
"value": "5000.00"
marcoscaceres marked this conversation as resolved.
Show resolved Hide resolved
}
</pre>
<section>
Expand Down