Introduce Browser Permissions for WebDriver BiDi

[OrKoN]

Closes #424

The following tasks have been completed:

• Modified Web platform tests: Umbrella bug for WebDriver BiDi Browser Permissions API tests web-platform-tests/wpt#43305

Implementation commitment:

• WebKit
• Blink (link to issue): Umbrella bug for Browser Permissions API GoogleChromeLabs/chromium-bidi#1585
• Gecko (link to issue): WebDriver-BiDi extension module: Browser Permissions API mozilla/standards-positions#930

Based on #425 by @thiagowfx

---

Preview | Diff

[miketaylr]

@OrKoN I see this is currently a draft, happy to review when you think it's ready.

[OrKoN]

@miketaylr thanks! I double checked if I have included everything from the previous PR and looks like I fixed the compilation errors so I believe it's now ready for review.

[miketaylr]

LGTM, but let's get someone else to review as well (preferably someone more familiar with WebDriver-BiDi). :)

[marcoscaceres]

Filed WebKit bug...

hey, @gsnedders, would you mind having a look at this too?

[marcoscaceres]

@OrKoN, apart from tests, what else needs to happen on the WPT side? Do we need to add somethings to testdriver_vendor.js etc?

[OrKoN]

@marcoscaceres this PR replicates the WebDriver Classic functionality so there is no need to extend testdriver.js currently. For now we only plan to add WPT tests for the extension spec itself (similar to webdriver/tests/classic/permissions/set.py). Eventually we want to expose WebDriver BiDi via testdriver-vendor.js when there is a need to testing event-based features of WebDriver BiDi or if there are new BiDi features that are not available in WebDriver Classic.

[marcoscaceres]

We reviewed on the WebKit side and we are content for this to land too.

[OrKoN]

@miketaylr do you know if we need more reviewers? I can start working on WPT tests and Chrome implementation at the end of December. Should we wait until WPT tests are there before landing?

[miketaylr]

@miketaylr do you know if we need more reviewers? I can start working on WPT tests and Chrome implementation at the end of December. Should we wait until WPT tests are there before landing?

Nope - we're good on the review side of things, especially with WebKit's support. It would be ideal if the WPTs landed before we merged, but if you pinky swear to do them I don't mind merging now.

[OrKoN]

@miketaylr I have started WPT tests here web-platform-tests/wpt#43802 and started to work on the implementation. One thing I have noticed is that probably we would need to adjust the BiDi part of the spec text. In particular, Let settings be the current settings object. is ambiguous in the context of WebDriver BiDi and we should explicitly specify which browsing context to use. Does it make sense to make those changes in this PR and land it or start a new one?

[miketaylr]

@OrKoN let's do whatever is simplest for you. I'm happy to merge this as-is, and we can iterate in a new PR, or we can continue here.

[OrKoN]

@miketaylr I think it will be simpler to land this first so it's easier to review the differences and avoid merge conflicts. Would you mind merging the PR then?

[miketaylr]

Thanks Marcos! Sorry to have missed this notification @OrKoN...