Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wdspec] Add tests for permissions #43802

Merged
merged 5 commits into from
Jan 17, 2024
Merged

[wdspec] Add tests for permissions #43802

merged 5 commits into from
Jan 17, 2024

Conversation

OrKoN
Copy link
Contributor

@OrKoN OrKoN commented Dec 27, 2023 •
edited
Loading

@OrKoN OrKoN mentioned this pull request Dec 29, 2023
Merged
4 tasks
@OrKoN OrKoN force-pushed the orkon/permissions branch 4 times, most recently from b0fcf99 to 6239b77 Compare January 15, 2024 06:44
@OrKoN OrKoN mentioned this pull request Jan 16, 2024
Merged
@OrKoN OrKoN force-pushed the orkon/permissions branch from 6239b77 to 68376e3 Compare January 16, 2024 09:04
@OrKoN OrKoN force-pushed the orkon/permissions branch from 68376e3 to 8cf6d69 Compare January 16, 2024 09:13
@OrKoN OrKoN requested a review from sadym-chromium January 16, 2024 09:48
@OrKoN OrKoN force-pushed the orkon/permissions branch from 6c93cf3 to a4a891b Compare January 16, 2024 11:30
@OrKoN OrKoN force-pushed the orkon/permissions branch from f0de762 to 8a459d4 Compare January 16, 2024 13:28
@OrKoN OrKoN force-pushed the orkon/permissions branch from 8a459d4 to 0b8518f Compare January 16, 2024 13:47
@OrKoN OrKoN marked this pull request as ready for review January 16, 2024 13:51
@OrKoN @sadym-chromium
Update webdriver/tests/bidi/permissions/set_permission/set_permission.py
dd58d8d 
Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com>
@OrKoN @sadym-chromium
Update webdriver/tests/bidi/permissions/set_permission/set_permission.py
77ff37a 
Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com>
@OrKoN OrKoN merged commit 8cbef37 into master Jan 17, 2024
41 checks passed
@OrKoN OrKoN deleted the orkon/permissions branch January 17, 2024 10:36
OrKoN added a commit to GoogleChromeLabs/chromium-bidi that referenced this pull request Jan 17, 2024
@OrKoN @sadym-chromium
feat: implement permissions (#1645)
29c7b0b 
Spec: https://www.w3.org/TR/permissions/#automation-webdriver-bidi
Tests: web-platform-tests/wpt#43802

---------

Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com>
@whimboo
Copy link
Contributor

whimboo commented Jan 17, 2024 •
edited
Loading

@OrKoN we do not have specs for this in BiDi so the tests should not have landed as is but marked with the tentative suffix in the test file name. Can you please get them all corrected? Thanks!

@OrKoN
Copy link
Contributor Author

OrKoN commented Jan 17, 2024

@whimboo the spec is here https://www.w3.org/TR/permissions/#automation-webdriver-bidi (same as webdriver/tests/classic/permissions/set.py)

@whimboo
Copy link
Contributor

whimboo commented Jan 17, 2024

Please note that you are adding a permissions module including commands for WebDriver BiDi. As long as this is not available in the BiDi spec the tests utilizing those commands have to be marked as tentative.

@jgraham
Copy link
Contributor

jgraham commented Jan 17, 2024

I don't think they need to be marked tentative, but I wonder if we should have a directory like webdriver/bidi/external/permissions or something. wpt limitations mean that all WebDriver tests have to be in webdriver/tests, but making it clear which ones are related to the base WebDriver spec and which are related to other specifications seems like it would be helpful.

@OrKoN
Copy link
Contributor Author

OrKoN commented Jan 17, 2024

I think moving to the external subfolder makes sense. I will open a PR!

@OrKoN
Copy link
Contributor Author

OrKoN commented Jan 17, 2024

#44045

marcoscaceres pushed a commit that referenced this pull request Feb 23, 2024
@OrKoN @sadym-chromium @marcoscaceres
[wdspec] Add tests for permissions (#43802)
1443c32 
* [wdspec] Add tests for permissions

* Add undefined tests

* add tests

* Update webdriver/tests/bidi/permissions/set_permission/set_permission.py

Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com>

* Update webdriver/tests/bidi/permissions/set_permission/set_permission.py

Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com>

---------

Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadym-chromium sadym-chromium sadym-chromium approved these changes

@AutomatedTester AutomatedTester Awaiting requested review from AutomatedTester

@DanielRyanSmith DanielRyanSmith Awaiting requested review from DanielRyanSmith

@foolip foolip Awaiting requested review from foolip

@jgraham jgraham Awaiting requested review from jgraham

@jrandolf-2 jrandolf-2 Awaiting requested review from jrandolf-2

@juliandescottes juliandescottes Awaiting requested review from juliandescottes

@shs96c shs96c Awaiting requested review from shs96c

@whimboo whimboo Awaiting requested review from whimboo

Assignees

@sadym-chromium sadym-chromium

Labels
infra webdriver webdriver-bidi wg-testing_browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Umbrella bug for WebDriver BiDi Browser Permissions API tests
5 participants
@OrKoN @whimboo @jgraham @sadym-chromium @wpt-pr-bot