Remove browser icons... #152
Conversation
Seeing the browser icons makes it look like everyone is implementing. That's clearly not the case.
There was a problem hiding this comment.
I will leave it to @beaufortfrancois but leaving some comments as I don't think the statuses are quite correct.
| @@ -32,13 +30,18 @@ Tip: Chrome channel releases are tracked at [https://googlechromelabs.github.io/ | |||
| * [Issue 854935](http://crbug.com/854935): Closed captions in Picture-in-Picture are not supported. | |||
|
|
|||
| # Microsoft Edge | |||
| https://dev.windows.com/en-us/microsoft-edge/platform/status/pictureinpicture | |||
| Under consideration. | |||
| https://developer.microsoft.com/en-us/microsoft-edge/platform/status/pictureinpicture/ | |||
There was a problem hiding this comment.
@MarionDaly, can you confirm? Edge planning to ship this too?
There was a problem hiding this comment.
Edge Canary channel has Picture-in-Picture API enabled as you can see.
There was a problem hiding this comment.
FYI I've opened #153
|
|
||
| # Safari | ||
| No public signals. |
There was a problem hiding this comment.
My understanding is that Safari is supportive and has their own private API.
There was a problem hiding this comment.
Oh, do they expose some webkitThing. thing?
There was a problem hiding this comment.
Yeah, I think it's something like video.webkitSetPresentationMode("picture-in-picture").
There was a problem hiding this comment.
Neat, I had no idea.
There was a problem hiding this comment.
From https://developers.google.com/web/updates/2018/10/watch-video-using-picture-in-picture#background,
In September 2016, Safari added Picture-in-Picture support through a WebKit API in macOS Sierra. Six months later, Chrome automatically played Picture-in-Picture video on mobile with the release of Android O using a native Android API. Six months later, we announced our intent to build and standardize a Web API, feature compatible with Safari’s, that would allow web developers to create and control the full experience around Picture-in-Picture. And here we are!
There was a problem hiding this comment.
Moreover, they're accepting patches for review: https://bugs.webkit.org/show_bug.cgi?id=189848#c8
There was a problem hiding this comment.
Ok, nice. This is encouraging!
There was a problem hiding this comment.
FYI I've pushed #154
| https://bugs.webkit.org/show_bug.cgi?id=182688 | ||
|
|
||
| # Firefox | ||
| No public signals. |
There was a problem hiding this comment.
I would say there was a lot of public signals ^_^
There was a problem hiding this comment.
Heh, our official(tm) position is to “defer”:
mozilla/standards-positions#72
That doesn’t mean we wont do it, just not right now.
There was a problem hiding this comment.
FYI I've opened #155
There was a problem hiding this comment.
So, Mozilla is happy for you all to figure out the spec details, tests, etc. Can you please ping me when you think the spec is CR ready and it’s in Safari Tech Preview? I think then might be a good time to re-evaluate adding the API. Given that we have PiP working, adding the DOM bits should be fairly trivial (famous last words).
|
I'll merge this PR for now and will start a PR for updating browsers vendor status. |
Seeing the browser icons makes it look like everyone is implementing. That's clearly not the case.