Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove browser icons... #152

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Remove browser icons... #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions implementation-status.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# Implementation Status
This document shows the current implementation status of Picture-in-Picture on the different browsers.

<a href="#chrome"><img width=64 src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/chrome/chrome_128x128.png" alt="Chrome browser logo"></a><a href="#microsoft-edge"><img width=64 src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/edge/edge_128x128.png" alt="Microsoft Edge browser logo"></a><a href="#safari"><img width=64 src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/safari/safari_128x128.png" alt="Safari browser logo"></a><a href="#firefox"><img width=64 src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/firefox/firefox_128x128.png" alt="Firefox browser logo"></a>

# Chrome

Work is still in progress in [Chrome Canary](http://chrome.com/canary):
Expand Down Expand Up @@ -32,13 +30,18 @@ Tip: Chrome channel releases are tracked at [https://googlechromelabs.github.io/
* [Issue 854935](http://crbug.com/854935): Closed captions in Picture-in-Picture are not supported.

# Microsoft Edge
https://dev.windows.com/en-us/microsoft-edge/platform/status/pictureinpicture
Under consideration.
https://developer.microsoft.com/en-us/microsoft-edge/platform/status/pictureinpicture/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edgium has the feature.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarionDaly, can you confirm? Edge planning to ship this too?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edge Canary channel has Picture-in-Picture API enabled as you can see.
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I've opened #153


# Safari
No public signals.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that Safari is supportive and has their own private API.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, do they expose some webkitThing. thing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think it's something like video.webkitSetPresentationMode("picture-in-picture").

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, I had no idea.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From https://developers.google.com/web/updates/2018/10/watch-video-using-picture-in-picture#background,

In September 2016, Safari added Picture-in-Picture support through a WebKit API in macOS Sierra. Six months later, Chrome automatically played Picture-in-Picture video on mobile with the release of Android O using a native Android API. Six months later, we announced our intent to build and standardize a Web API, feature compatible with Safari’s, that would allow web developers to create and control the full experience around Picture-in-Picture. And here we are!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moreover, they're accepting patches for review: https://bugs.webkit.org/show_bug.cgi?id=189848#c8

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, nice. This is encouraging!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I've pushed #154

https://bugs.webkit.org/show_bug.cgi?id=182688

# Firefox
No public signals.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say there was a lot of public signals ^_^

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, our official(tm) position is to “defer”:
mozilla/standards-positions#72

That doesn’t mean we wont do it, just not right now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I've opened #155

Copy link
Member Author

@marcoscaceres marcoscaceres Jul 15, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, Mozilla is happy for you all to figure out the spec details, tests, etc. Can you please ping me when you think the spec is CR ready and it’s in Safari Tech Preview? I think then might be a good time to re-evaluate adding the API. Given that we have PiP working, adding the DOM bits should be fairly trivial (famous last words).

https://bugzilla.mozilla.org/show_bug.cgi?id=1463402

Mozilla position: https://github.com/mozilla/standards-positions/issues/72

# Polyfill
https://github.com/gbentaieb/pip-polyfill/