Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for VC-JOSE-COSE #28

Merged
merged 12 commits into from
Jun 8, 2024
Merged

Add rendering for VC-JOSE-COSE #28

merged 12 commits into from
Jun 8, 2024

Conversation

decentralgabe
Copy link
Collaborator

Fix #9

Migrated code from https://github.com/w3c/vc-jose-cose/tree/main/plugin here

Had to massage polyfills. Updated the README and examples. Looks good on my screen!

Note: the code works off a static P-384 key. We can adjust this to use the same key across all examples, but I figure this is a decent starting place.

…ose-cose

* refs/remotes/origin/main:
  Remove last remaining eslint complaints.
  Remove unused vcHashEntryIndex variable.
  Remove parens from single param functions.
  Sort imports.
  Update example image in README.md.
  Update respec-vc README and CHANGELOG for v3.1.0 release.
  Implement generating hashes for context and vocabulary files.
  Reorder default tab order.
  Refactor proof generation and tab titles.
  Add bbs-2023 integration.
  Add ecdsa-rdfc-2019.

# Conflicts:
#	README.md
#	index.js
#	package.json
@decentralgabe
Copy link
Collaborator Author

friendly bump @msporny @BigBlueHat

@msporny msporny merged commit 1318aa6 into main Jun 8, 2024
1 check passed
@msporny msporny deleted the add-vc-jose-cose branch June 8, 2024 15:27
@msporny
Copy link
Member

msporny commented Jun 8, 2024

friendly bump @msporny @BigBlueHat

Thanks for the bump @decentralgabe, I missed the original PR request.

@msporny
Copy link
Member

msporny commented Jun 8, 2024

Hrm, this PR seems to have broken all the fixes we've done in the past few weeks... I'm going to restore the branch to figure out what went wrong...

Yeah, this PR deletes features added over the past two weeks:

https://github.com/w3c/respec-vc/pull/28/files#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346L11-L18

https://github.com/w3c/respec-vc/pull/28/files#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346L31-L37

https://github.com/w3c/respec-vc/pull/28/files#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346L65-L188

Looks like it was based on an old copy of main that needed to be updated, and this PR rebased on top of it. Sorry that I didn't catch this before merging.

@decentralgabe, can you please look at what went wrong and rebase this branch and open a new PR that doesn't delete the tab rename and autohash generation feature set?

@msporny msporny restored the add-vc-jose-cose branch June 8, 2024 15:35
@msporny
Copy link
Member

msporny commented Jun 8, 2024

@decentralgabe, can you please look at what went wrong and rebase this branch and open a new PR that doesn't delete the tab rename and autohash generation feature set?

I tried rebasing and fixing merges for two hours and couldn't fix the new babel-induced errors. I have little understanding of all the code being pulled in, and am now out of time to try and debug further. /cc @BigBlueHat and @tminard in case they might have an easier time doing a rebase with this code base w/o removing the tab renaming and autohash code.

@decentralgabe decentralgabe deleted the add-vc-jose-cose branch June 11, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate VC-JOSE-COSE
2 participants