Add VC-JOSE-COSE Rendering (Take 2) #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ose-cose * refs/remotes/origin/main: Remove last remaining eslint complaints. Remove unused vcHashEntryIndex variable. Remove parens from single param functions. Sort imports. Update example image in README.md. Update respec-vc README and CHANGELOG for v3.1.0 release. Implement generating hashes for context and vocabulary files. Reorder default tab order. Refactor proof generation and tab titles. Add bbs-2023 integration. Add ecdsa-rdfc-2019. # Conflicts: # README.md # index.js # package.json
decentralgabe
requested review from
msporny and
BigBlueHat
and removed request for
msporny
|
nudge nudge @msporny |
|
Apologies, again, @decentralgabe -- don't know why I'm not getting notifications to review from Github. I'll have to look at my very aggressive inbox filters; review requests are probably getting filtered to the "github" inbox, which gets hundreds of notifications per day. |
|
Checked locally, everything seems to work! Hooray! I'll get a new release out now so we can pull it into the VCWG specs. One thing I noted was that the cose stuff seems broken? It doesn't seem to include the payload? (payload is nil). Is this expected behaviour? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge of #28 into current main
As a bonus, the key is no longer static...