support attached COSE payloads and presentations #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 27, 2024
TallTed
reviewed
Jul 1, 2024
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
|
nudge @msporny hope we can get this in and then adjust the media types when things settle |
msporny
approved these changes
Jul 2, 2024
|
Merged and released v3.3.0 -- can you please check to make sure it does what you expect it to, @decentralgabe? I tested it locally on the test document you provided and it seemed to work for me. |
|
lgtm thanks @msporny |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #31
Also added support for rendering presentation examples, I've only enabled this for vc-jose-cose work for now.
There is also #30 which I believe should follow this once media types settle down.