Un-deprecated child-src #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikewest
reviewed
Jun 6, 2018
| if not present (which likewise defers to `default-src` in turn). | ||
| 2. A `worker-src` directive has been added, deferring to `child-src` | ||
| if not present (which likewise defers to `script-src` and | ||
| eventually `default-src`). |
There was a problem hiding this comment.
This doesn't really explain to me what the chain is. Did we end up with worker-src -> script-src -> child-src -> default-src? It would be helpful to spell the inheritance out more clearly. :)
There was a problem hiding this comment.
The inheritance we ended up going with is worker-src -> child-src -> script-src -> default-src.
| @@ -1889,7 +1884,7 @@ <h5 algorithm id="child-src-post-request"> | |||
| 1. Let |name| be the result of executing | |||
| [[#effective-directive-for-a-request]] on |request|. | |||
|
|
|||
| 2. If |name| is not `frame-src`, return "`Allowed`". | |||
| 2. If |name| is not `frame-src` or `worker-src`, return "`Allowed`". | |||
|
|
|||
| 3. If |policy| contains a directive whose <a for="directive">name</a> | |||
| is |name|, return "`Allowed`" | |||
There was a problem hiding this comment.
I think you need to check for script-src somewhere in here as well, right? Just as you do below in default-src?
There was a problem hiding this comment.
No, the chain is the other way around. I check for the presence of child-src in script-src.
There was a problem hiding this comment.
Hrm. Ok. And you'll presumably extend that to check for script-whatever in an upcoming patch?
mikewest
approved these changes
Jun 7, 2018
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 6, 2018
'child-src' is now part of the fallback chain for 'worker-src'.
This means that if 'child-src' always takes precedence over 'script-src'
when checking worker requests.
Added extra tests to ensure that a worker request blocked by
'child-src' and allowed by 'script-src' is blocked.
Removed previous logic that considered 'script-src' to be the
fallback for 'worker-src' and amended tests. Removed "temporary"
logic put in place to not brake "child-src" using sites.
Refactored the OperativeDirective logic to ensure that the caller
does not need to be aware of precise fallback chain of the directive,
otherwise the way to get the 'worker-src' operative directive would be:
OperativeDirective(worker_src_.Get(),
OperativeDirective(child_src_.Get(),
OperativeDirective(script_src_.Get())));
To be submitted with the spec PR as it includes tests.
Spec: w3c/webappsec-csp#313
Bug: 669496
Change-Id: I7ca9552df1d0ce203a604b0e469a268f6b112e49
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 9, 2018
'child-src' is now part of the fallback chain for 'worker-src'.
This means that 'child-src' always takes precedence over 'script-src'
when checking worker requests.
Added extra tests to ensure that a worker request blocked by
'child-src' and allowed by 'script-src' is blocked.
Removed previous logic that considered 'script-src' to be the
fallback for 'worker-src' and amended tests. Removed "temporary"
logic put in place to not break sites using "child-src".
Refactored the OperativeDirective logic to ensure that the caller
does not need to be aware of precise fallback chain of the directive,
otherwise the way to get the 'worker-src' operative directive would be:
OperativeDirective(worker_src_.Get(),
OperativeDirective(child_src_.Get(),
OperativeDirective(script_src_.Get())));
To be submitted with the spec PR as it includes tests.
Spec: w3c/webappsec-csp#313
Bug: 669496
Change-Id: I7ca9552df1d0ce203a604b0e469a268f6b112e49
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 9, 2018
'child-src' is now part of the fallback chain for 'worker-src'.
This means that 'child-src' always takes precedence over 'script-src'
when checking worker requests.
Added extra tests to ensure that a worker request blocked by
'child-src' and allowed by 'script-src' is blocked.
Removed previous logic that considered 'script-src' to be the
fallback for 'worker-src' and amended tests. Removed "temporary"
logic put in place to not break sites using "child-src".
Refactored the OperativeDirective logic to ensure that the caller
does not need to be aware of precise fallback chain of the directive,
otherwise the way to get the 'worker-src' operative directive would be:
OperativeDirective(worker_src_.Get(),
OperativeDirective(child_src_.Get(),
OperativeDirective(script_src_.Get())));
To be submitted with the spec PR as it includes tests.
Spec: w3c/webappsec-csp#313
Bug: 669496
Change-Id: I7ca9552df1d0ce203a604b0e469a268f6b112e49
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jul 9, 2018
'child-src' is now part of the fallback chain for 'worker-src'.
This means that 'child-src' always takes precedence over 'script-src'
when checking worker requests.
Added extra tests to ensure that a worker request blocked by
'child-src' and allowed by 'script-src' is blocked.
Removed previous logic that considered 'script-src' to be the
fallback for 'worker-src' and amended tests. Removed "temporary"
logic put in place to not break sites using "child-src".
Refactored the OperativeDirective logic to ensure that the caller
does not need to be aware of precise fallback chain of the directive,
otherwise the way to get the 'worker-src' operative directive would be:
OperativeDirective(worker_src_.Get(),
OperativeDirective(child_src_.Get(),
OperativeDirective(script_src_.Get())));
To be submitted with the spec PR as it includes tests.
Spec: w3c/webappsec-csp#313
Bug: 669496
Change-Id: I7ca9552df1d0ce203a604b0e469a268f6b112e49
Reviewed-on: https://chromium-review.googlesource.com/1128087
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573278}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 9, 2018
'child-src' is now part of the fallback chain for 'worker-src'.
This means that 'child-src' always takes precedence over 'script-src'
when checking worker requests.
Added extra tests to ensure that a worker request blocked by
'child-src' and allowed by 'script-src' is blocked.
Removed previous logic that considered 'script-src' to be the
fallback for 'worker-src' and amended tests. Removed "temporary"
logic put in place to not break sites using "child-src".
Refactored the OperativeDirective logic to ensure that the caller
does not need to be aware of precise fallback chain of the directive,
otherwise the way to get the 'worker-src' operative directive would be:
OperativeDirective(worker_src_.Get(),
OperativeDirective(child_src_.Get(),
OperativeDirective(script_src_.Get())));
To be submitted with the spec PR as it includes tests.
Spec: w3c/webappsec-csp#313
Bug: 669496
Change-Id: I7ca9552df1d0ce203a604b0e469a268f6b112e49
Reviewed-on: https://chromium-review.googlesource.com/1128087
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573278}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 9, 2018
'child-src' is now part of the fallback chain for 'worker-src'.
This means that 'child-src' always takes precedence over 'script-src'
when checking worker requests.
Added extra tests to ensure that a worker request blocked by
'child-src' and allowed by 'script-src' is blocked.
Removed previous logic that considered 'script-src' to be the
fallback for 'worker-src' and amended tests. Removed "temporary"
logic put in place to not break sites using "child-src".
Refactored the OperativeDirective logic to ensure that the caller
does not need to be aware of precise fallback chain of the directive,
otherwise the way to get the 'worker-src' operative directive would be:
OperativeDirective(worker_src_.Get(),
OperativeDirective(child_src_.Get(),
OperativeDirective(script_src_.Get())));
To be submitted with the spec PR as it includes tests.
Spec: w3c/webappsec-csp#313
Bug: 669496
Change-Id: I7ca9552df1d0ce203a604b0e469a268f6b112e49
Reviewed-on: https://chromium-review.googlesource.com/1128087
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573278}
andypaicu
force-pushed
the
child-src-undep
branch
from
7b84ec4 to
af9db19
Compare
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 20, 2018
Automatic update from web-platform-testsUn-deprecated 'child-src'
'child-src' is now part of the fallback chain for 'worker-src'.
This means that 'child-src' always takes precedence over 'script-src'
when checking worker requests.
Added extra tests to ensure that a worker request blocked by
'child-src' and allowed by 'script-src' is blocked.
Removed previous logic that considered 'script-src' to be the
fallback for 'worker-src' and amended tests. Removed "temporary"
logic put in place to not break sites using "child-src".
Refactored the OperativeDirective logic to ensure that the caller
does not need to be aware of precise fallback chain of the directive,
otherwise the way to get the 'worker-src' operative directive would be:
OperativeDirective(worker_src_.Get(),
OperativeDirective(child_src_.Get(),
OperativeDirective(script_src_.Get())));
To be submitted with the spec PR as it includes tests.
Spec: w3c/webappsec-csp#313
Bug: 669496
Change-Id: I7ca9552df1d0ce203a604b0e469a268f6b112e49
Reviewed-on: https://chromium-review.googlesource.com/1128087
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573278}
--
wpt-commits: dceb242f223cae966354d8d4558492b28f9238cf
wpt-pr: 11838
jankeromnes
pushed a commit
to jankeromnes/gecko
that referenced
this pull request
Jul 23, 2018
Automatic update from web-platform-testsUn-deprecated 'child-src'
'child-src' is now part of the fallback chain for 'worker-src'.
This means that 'child-src' always takes precedence over 'script-src'
when checking worker requests.
Added extra tests to ensure that a worker request blocked by
'child-src' and allowed by 'script-src' is blocked.
Removed previous logic that considered 'script-src' to be the
fallback for 'worker-src' and amended tests. Removed "temporary"
logic put in place to not break sites using "child-src".
Refactored the OperativeDirective logic to ensure that the caller
does not need to be aware of precise fallback chain of the directive,
otherwise the way to get the 'worker-src' operative directive would be:
OperativeDirective(worker_src_.Get(),
OperativeDirective(child_src_.Get(),
OperativeDirective(script_src_.Get())));
To be submitted with the spec PR as it includes tests.
Spec: w3c/webappsec-csp#313
Bug: 669496
Change-Id: I7ca9552df1d0ce203a604b0e469a268f6b112e49
Reviewed-on: https://chromium-review.googlesource.com/1128087
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573278}
--
wpt-commits: dceb242f223cae966354d8d4558492b28f9238cf
wpt-pr: 11838
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
Automatic update from web-platform-testsUn-deprecated 'child-src'
'child-src' is now part of the fallback chain for 'worker-src'.
This means that 'child-src' always takes precedence over 'script-src'
when checking worker requests.
Added extra tests to ensure that a worker request blocked by
'child-src' and allowed by 'script-src' is blocked.
Removed previous logic that considered 'script-src' to be the
fallback for 'worker-src' and amended tests. Removed "temporary"
logic put in place to not break sites using "child-src".
Refactored the OperativeDirective logic to ensure that the caller
does not need to be aware of precise fallback chain of the directive,
otherwise the way to get the 'worker-src' operative directive would be:
OperativeDirective(worker_src_.Get(),
OperativeDirective(child_src_.Get(),
OperativeDirective(script_src_.Get())));
To be submitted with the spec PR as it includes tests.
Spec: w3c/webappsec-csp#313
Bug: 669496
Change-Id: I7ca9552df1d0ce203a604b0e469a268f6b112e49
Reviewed-on: https://chromium-review.googlesource.com/1128087
Commit-Queue: Andy Paicu <andypaicuchromium.org>
Reviewed-by: Mike West <mkwstchromium.org>
Cr-Commit-Position: refs/heads/master{#573278}
--
wpt-commits: dceb242f223cae966354d8d4558492b28f9238cf
wpt-pr: 11838
UltraBlame original commit: 80e0f50335811cd740bbfbeb3d6e765d650b4400
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
Automatic update from web-platform-testsUn-deprecated 'child-src'
'child-src' is now part of the fallback chain for 'worker-src'.
This means that 'child-src' always takes precedence over 'script-src'
when checking worker requests.
Added extra tests to ensure that a worker request blocked by
'child-src' and allowed by 'script-src' is blocked.
Removed previous logic that considered 'script-src' to be the
fallback for 'worker-src' and amended tests. Removed "temporary"
logic put in place to not break sites using "child-src".
Refactored the OperativeDirective logic to ensure that the caller
does not need to be aware of precise fallback chain of the directive,
otherwise the way to get the 'worker-src' operative directive would be:
OperativeDirective(worker_src_.Get(),
OperativeDirective(child_src_.Get(),
OperativeDirective(script_src_.Get())));
To be submitted with the spec PR as it includes tests.
Spec: w3c/webappsec-csp#313
Bug: 669496
Change-Id: I7ca9552df1d0ce203a604b0e469a268f6b112e49
Reviewed-on: https://chromium-review.googlesource.com/1128087
Commit-Queue: Andy Paicu <andypaicuchromium.org>
Reviewed-by: Mike West <mkwstchromium.org>
Cr-Commit-Position: refs/heads/master{#573278}
--
wpt-commits: dceb242f223cae966354d8d4558492b28f9238cf
wpt-pr: 11838
UltraBlame original commit: 80e0f50335811cd740bbfbeb3d6e765d650b4400
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
Automatic update from web-platform-testsUn-deprecated 'child-src'
'child-src' is now part of the fallback chain for 'worker-src'.
This means that 'child-src' always takes precedence over 'script-src'
when checking worker requests.
Added extra tests to ensure that a worker request blocked by
'child-src' and allowed by 'script-src' is blocked.
Removed previous logic that considered 'script-src' to be the
fallback for 'worker-src' and amended tests. Removed "temporary"
logic put in place to not break sites using "child-src".
Refactored the OperativeDirective logic to ensure that the caller
does not need to be aware of precise fallback chain of the directive,
otherwise the way to get the 'worker-src' operative directive would be:
OperativeDirective(worker_src_.Get(),
OperativeDirective(child_src_.Get(),
OperativeDirective(script_src_.Get())));
To be submitted with the spec PR as it includes tests.
Spec: w3c/webappsec-csp#313
Bug: 669496
Change-Id: I7ca9552df1d0ce203a604b0e469a268f6b112e49
Reviewed-on: https://chromium-review.googlesource.com/1128087
Commit-Queue: Andy Paicu <andypaicuchromium.org>
Reviewed-by: Mike West <mkwstchromium.org>
Cr-Commit-Position: refs/heads/master{#573278}
--
wpt-commits: dceb242f223cae966354d8d4558492b28f9238cf
wpt-pr: 11838
UltraBlame original commit: 80e0f50335811cd740bbfbeb3d6e765d650b4400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#239
#299
Preview | Diff