Un-deprecated 'child-src' #11838
Merged
Un-deprecated 'child-src' #11838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 6, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1128087
branch
2 times, most recently
from
d963f66 to
16b7052
Compare
'child-src' is now part of the fallback chain for 'worker-src'.
This means that 'child-src' always takes precedence over 'script-src'
when checking worker requests.
Added extra tests to ensure that a worker request blocked by
'child-src' and allowed by 'script-src' is blocked.
Removed previous logic that considered 'script-src' to be the
fallback for 'worker-src' and amended tests. Removed "temporary"
logic put in place to not break sites using "child-src".
Refactored the OperativeDirective logic to ensure that the caller
does not need to be aware of precise fallback chain of the directive,
otherwise the way to get the 'worker-src' operative directive would be:
OperativeDirective(worker_src_.Get(),
OperativeDirective(child_src_.Get(),
OperativeDirective(script_src_.Get())));
To be submitted with the spec PR as it includes tests.
Spec: w3c/webappsec-csp#313
Bug: 669496
Change-Id: I7ca9552df1d0ce203a604b0e469a268f6b112e49
Reviewed-on: https://chromium-review.googlesource.com/1128087
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573278}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1128087
branch
from
16b7052 to
fbd298e
Compare
andypaicu
added a commit
to w3c/webappsec-csp
that referenced
this pull request
Jul 10, 2018
* Un-deprecated child-src * tests added in web-platform-tests/wpt#11838
ryandel8834
added a commit
to ryandel8834/WebAppSec-CSP
that referenced
this pull request
Aug 13, 2022
* Un-deprecated child-src * tests added in web-platform-tests/wpt#11838
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'child-src' is now part of the fallback chain for 'worker-src'.
This means that 'child-src' always takes precedence over 'script-src'
when checking worker requests.
Added extra tests to ensure that a worker request blocked by
'child-src' and allowed by 'script-src' is blocked.
Removed previous logic that considered 'script-src' to be the
fallback for 'worker-src' and amended tests. Removed "temporary"
logic put in place to not break sites using "child-src".
Refactored the OperativeDirective logic to ensure that the caller
does not need to be aware of precise fallback chain of the directive,
otherwise the way to get the 'worker-src' operative directive would be:
OperativeDirective(worker_src_.Get(),
OperativeDirective(child_src_.Get(),
OperativeDirective(script_src_.Get())));
To be submitted with the spec PR as it includes tests.
Spec: w3c/webappsec-csp#313
Bug: 669496
Change-Id: I7ca9552df1d0ce203a604b0e469a268f6b112e49
Reviewed-on: https://chromium-review.googlesource.com/1128087
Commit-Queue: Andy Paicu andypaicu@chromium.org
Reviewed-by: Mike West mkwst@chromium.org
Cr-Commit-Position: refs/heads/master@{#573278}