Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintain an internal slot of candidate pairs that are valid inputs to RTCIceTransport operations #188

Closed
sam-vi opened this issue Nov 6, 2023 · 1 comment · Fixed by #197
Closed

Maintain an internal slot of candidate pairs that are valid inputs to RTCIceTransport operations #188

sam-vi opened this issue Nov 6, 2023 · 1 comment · Fixed by #197
Assignees
@sam-vi

Comments

@sam-vi
Copy link
Contributor

sam-vi commented Nov 6, 2023

An internal slot of [[ActiveCandidatePairs]] can track candidate pairs that are

  • added when sent in onicecandidatepairadd
  • removed when sent in onicecandidatepairremove, which is not canceled
  • removed when supplied to removeCandidatePairs

This makes it explicit and possible to validate synchronously whether an input to an RTCIceTransport operation is valid.
@sam-vi sam-vi mentioned this issue Nov 6, 2023
Merged
@jan-ivar
Copy link
Member

jan-ivar commented Nov 7, 2023

It might make sense to build this on top of w3c/webrtc-pc#2906.

sam-vi added a commit to sam-vi/webrtc-extensions that referenced this issue Dec 20, 2023
@sam-vi
Define an RTCIceCandidate match algorithm.
e7fe0e6 
Fixes: w3c#186.

The algorithm matches the (non-derived) candidate, sdpMid,
sdpMLineIndex, and usernameFragment attributes of RTCIceCandidate.

The candidate match algorithm will be used in the candidate pair match
algorithm (w3c#187), which will, in turn, be used in validation steps for
RTCIceTransport methods (w3c#188).
@sam-vi sam-vi mentioned this issue Dec 20, 2023
Merged
sam-vi added a commit to sam-vi/webrtc-extensions that referenced this issue Dec 20, 2023
@sam-vi
Define a candidate pair match algorithm.
4114dd0 
Fixes: w3c#187.

This PR depends on the candidate match algorithm described in w3c#192.

The candidate pair match algorithm will be used in validation steps for RTCIceTransport methods (w3c#188).
@sam-vi sam-vi mentioned this issue Dec 20, 2023
Merged
sam-vi added a commit to sam-vi/webrtc-extensions that referenced this issue Jan 10, 2024
@sam-vi
Add an internal slot for active candidate pairs.
9a97fe2 
Fixes: w3c#188.

The [[CandidatePairs]] slot in RTCIceTransport tracks candidate pairs
formed by the ICE agent and surfaced to the application, and not removed
via icecandidatepairremove or removeCandidatePair().

The slot is used to validate the inputs to selectCandidatePair() and
removeCandidatePair().
@sam-vi sam-vi mentioned this issue Jan 10, 2024
Closed
@henbos henbos mentioned this issue Jan 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sam-vi sam-vi

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sam-vi @jan-ivar