Add an internal slot for active candidate pairs. #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: w3c#188. The [[CandidatePairs]] slot in RTCIceTransport tracks candidate pairs formed by the ICE agent and surfaced to the application, and not removed via icecandidatepairremove or removeCandidatePair(). The slot is used to validate the inputs to selectCandidatePair() and removeCandidatePair().
sam-vi
added a commit
to sam-vi/webrtc-extensions
that referenced
this pull request
Jan 10, 2024
This depends on several other PRs to be merged first: - w3c#170: Addition of removeCandidatePair method - w3c#192: Definition of candidate match algo - alternately, w3c/webrtc-pc#2906 to enforce RTCIceCandidate object equality - w3c#193: Definition of candidate pair match algo - w3c#194: Addition of CandidatePairs internal slot
sam-vi
added a commit
to sam-vi/webrtc-extensions
that referenced
this pull request
Jan 10, 2024
This depends on several other PRs to be merged first: - w3c#170: Addition of removeCandidatePair method - w3c#192: Definition of candidate match algo - alternately, w3c/webrtc-pc#2906 to enforce RTCIceCandidate object equality - w3c#193: Definition of candidate pair match algo - w3c#194: Addition of CandidatePairs internal slot
sam-vi
added a commit
to sam-vi/webrtc-extensions
that referenced
this pull request
Jan 12, 2024
This depends on several other PRs to be merged first: - w3c#170: Addition of removeCandidatePair method - w3c#192: Definition of candidate match algo - alternately, w3c/webrtc-pc#2906 to enforce RTCIceCandidate object equality - w3c#193: Definition of candidate pair match algo - w3c#194: Addition of CandidatePairs internal slot
sam-vi
added a commit
to sam-vi/webrtc-extensions
that referenced
this pull request
Jan 12, 2024
Instead, there should be a requirement on the user agent to validate the application's input. This requirement is added by w3c#194.
sam-vi
added a commit
to sam-vi/webrtc-extensions
that referenced
this pull request
Jan 12, 2024
This depends on several other PRs to be merged first: - w3c#170: Addition of removeCandidatePair method - w3c#192: Definition of candidate match algo - alternately, w3c/webrtc-pc#2906 to enforce RTCIceCandidate object equality - w3c#193: Definition of candidate pair match algo - w3c#194: Addition of CandidatePairs internal slot
jan-ivar
reviewed
Jan 18, 2024
index.html
Outdated
Comment on lines
750
to
757
| Let |transport:RTCIceTransport| be the {{RTCIceTransport}} object associated with |candidatePair|. | ||
| </p> | ||
| </li> | ||
| <li> | ||
| <p> | ||
| [= list/Append =] |candidatePair| to {{RTCIceTransport/[[CandidatePairs]]}}. | ||
| </p> | ||
| </li> |
There was a problem hiding this comment.
Github won't let me comment on the line directly above this section, which is:
<p>
Let |candidatePair:RTCIceCandidatePair| be the candidate pair that was [= formed =].
</p>While readers can hover over the candidatePair variable to learn its type, I think we need to spell out in prose what the type is now, since to a non-interactive reader candidatePair reads like an internal concept so far in this algorithm. We need to expound on its type before adding it to [[CandidatePairs]] since objects there need to be usable with the new match algorithm.
Also this appears to be the right place to instantiate candidate interfaces. Something like (updated):
<p>
Let |candidatePair:RTCIceCandidatePair| be a new {{RTCIceCandidatePair}} dictionary
with its {{RTCIceCandidatePair/local}} and {{RTCIceCandidatePair/remote}} members
initialized to new {{RTCIceCandidate}}s representing the local and remote part of the
[= formed =] pair respectively.
</p>There was a problem hiding this comment.
To help Sameer make progress while OOO, I re-uploaded this PR as #197 with this comment addressed
jan-ivar
requested changes
Jan 18, 2024
jan-ivar
reviewed
Jan 18, 2024
| </li> | ||
| <li> | ||
| <p> | ||
| [= list/Remove =] all items that [= candidate pair match | match =] |candidatePair| from [=this=].{{RTCIceTransport/[[CandidatePairs]]}}. | ||
| </p> | ||
| </li> | ||
| <li> |
There was a problem hiding this comment.
Also, do we need to clear [[CandidatePairs]] at some point during ICE restart?
There was a problem hiding this comment.
Good question, I filed #196 to decide if we need to add more steps or if this is already covered by the existing removal steps, including whether or not the onicecandidatepairremoved should fire?
Co-authored-by: Jan-Ivar Bruaroey <jan-ivar@users.noreply.github.com>
Co-authored-by: Jan-Ivar Bruaroey <jan-ivar@users.noreply.github.com>
henbos
reviewed
Jan 25, 2024
henbos
reviewed
Jan 25, 2024
Co-authored-by: Jan-Ivar Bruaroey <jan-ivar@users.noreply.github.com>
This was referenced Jan 25, 2024
|
Merged as #197 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #188.
The [[CandidatePairs]] slot in RTCIceTransport tracks candidate pairs formed by the ICE agent and surfaced to the application, and not removed via icecandidatepairremove or removeCandidatePair().
The slot is used to validate the inputs to selectCandidatePair() and removeCandidatePair().
EDIT: To help Sameer make progress while OOO, I've re-uploaded this as #197 with comments addressed.
Preview | Diff