Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a note controlling exposure of remote candidate addresses #381

Merged
merged 5 commits into from
Dec 12, 2018
Merged

Add a note controlling exposure of remote candidate addresses #381

merged 5 commits into from
Dec 12, 2018

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Oct 31, 2018

No description provided.

@youennf youennf mentioned this pull request Oct 31, 2018
Closed
alvestrand
alvestrand reviewed Nov 5, 2018
View reviewed changes
Copy link
Contributor

@alvestrand alvestrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to fix the "note" thing, for process reasons. Should say "what do I do instead".

webrtc-stats.html Outdated Show resolved Hide resolved
webrtc-stats.html Outdated Show resolved Hide resolved
@youennf
Copy link
Contributor Author

youennf commented Nov 5, 2018

Uploaded related WPT test PR at web-platform-tests/wpt#13922

@youennf
Copy link
Contributor Author

youennf commented Nov 6, 2018

Uploaded related WPT test PR at web-platform-tests/wpt#13922

Written in terms of 'undefined'

alvestrand
alvestrand reviewed Nov 14, 2018
View reviewed changes
webrtc-stats.html Outdated Show resolved Hide resolved
@alvestrand
Copy link
Contributor

@youennf ping?

@youennf
Copy link
Contributor Author

youennf commented Nov 30, 2018

@alvestrand, thanks for the ping. Could you take another look?

alvestrand
alvestrand approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@alvestrand alvestrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This satisfies my concern. Thank you!

@alvestrand alvestrand merged commit ee1c517 into w3c:master Dec 12, 2018
@vr000m
Copy link
Contributor

vr000m commented Dec 12, 2018

LGTM

@fippo fippo mentioned this pull request Mar 24, 2021
Open
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
@fippo @copybara-github
webrtc: add address as alias for ip
1a4506b 
this was renamed in w3c/webrtc-pc#1913 and w3c/webrtc-stats#381
Spec: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-address

BUG=chromium:968203

Change-Id: I5e23e27c68c766188b81ed244e327c1cfb6b1a51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2780267
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#866151}
GitOrigin-RevId: 5ceb883a824c4ed7f37f85569ec38b213ea2562a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vr000m vr000m vr000m left review comments

@alvestrand alvestrand alvestrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youennf @alvestrand @vr000m