Ensure that the 'address' member remains null in RTCIceCandidateStats for remote prflx candidates #13922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Stats for remote prflx candidates
jan-ivar
reviewed
Dec 11, 2018
|
|
||
| localPc.addEventListener('icecandidate', event => { | ||
| if (event.candidate) | ||
| remotePc.addIceCandidate(event.candidate); |
There was a problem hiding this comment.
Tip: There's already an (imperfect) exchangeIceCandidates() helper for this. Maybe we could fix it and use that instead?
This also reminded me to open w3c/webrtc-pc#2039.
There was a problem hiding this comment.
There was a problem hiding this comment.
We probably could, but PR is not landed and test is already written so I would prefer just landing it as is for now.
youennf
changed the title
|
ping review. |
|
This PR is blocked on the required "Travis CI - Pull Request" check after #14499. In order to trigger it, I will close and reopen this PR. |
henbos
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.