fix uri variable example #2117
Merged
fix uri variable example #2117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Reviewed in the TD call, merging |
Member
|
It seems rather odd for a "simple oversight in an example" to change ~5000 lines. This might want another look. |
Contributor
Author
That is true but index.html is always auto-generated. All the changes seem like formatting changes though. I will have a deeper look. |
Contributor
Author
|
It seems I forgot to run format and just did with b0fbec2 . Not sure why the gh action did not show a failure... |
egekorkan
added a commit
that referenced
this pull request
Jul 17, 2025
Member
Ah. Bitten by artefacts being kept in source management. Best to avoid this, wherever and whenever possible. |
egekorkan
added a commit
that referenced
this pull request
Aug 7, 2025
* start reorganizing the intro for bindings * Apply suggestions from code review Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com> * change to td 2.0 and fix broken links (#2113) * change to td 2.0 and fix broken links * use version correctly * run formatting * fix: remove _value suffix from enum (#2117) * chore: run format * start reorganizing the intro for bindings * chore: run format * add prettier to rendering script * finish the basic intro for bindings * fix conflicts * rework other binding sections * adapt platform binding text and remove respec errors * Apply suggestions from code review Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com> * fix english mistakes * Apply suggestions from code review Co-authored-by: danielpeintner <daniel.peintner@gmail.com> * Apply suggestions from code review Co-authored-by: danielpeintner <daniel.peintner@gmail.com> * fix linking mistakes --------- Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com> Co-authored-by: danielpeintner <daniel.peintner@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Just a simple oversight in an example mentioned in #2038
Related Issue
Closes #2038
Type of Change
Preview | Diff