Binding Intro Reorganization #2118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallTed
suggested changes
Jul 16, 2025
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
* change to td 2.0 and fix broken links * use version correctly * run formatting
Contributor
Author
|
This PR is now ready for reviews. It is a lot of change from the git diff but it should be easy to read in the preview links. |
6 tasks
egekorkan
commented
Jul 30, 2025
TallTed
suggested changes
Jul 30, 2025
Member
TallTed
left a comment
TallTed
left a comment
There was a problem hiding this comment.
Grammar, punctuation, and such.
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Contributor
Author
|
Thank you @TallTed for the review however you don't need to review the index.html as it is auto-generated |
danielpeintner
approved these changes
Aug 6, 2025
Contributor
danielpeintner
left a comment
danielpeintner
left a comment
There was a problem hiding this comment.
Looks good to me overall.
See below some parts to be fixed
Co-authored-by: danielpeintner <daniel.peintner@gmail.com>
Co-authored-by: danielpeintner <daniel.peintner@gmail.com>
Contributor
Author
|
TD Call: No objection to merge this PR after the linking issues mentioned by @danielpeintner are resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
I am reworking the intro to take into account the registry, the change of naming (binding template -> binding), and the existence of overlapping content.
Related Issue
Will close point 4 of #2112
Type of Change
Preview | Diff