feat!: @waku/discovery #1876
feat!: @waku/discovery #1876
Conversation
danisharora099
force-pushed
the
feat/waku-discovery
branch
7 times, most recently
from
e8f43b4 to
a02e6d9
Compare
size-limit report 📦
|
danisharora099
force-pushed
the
feat/waku-discovery
branch
from
4907079 to
961ce83
Compare
danisharora099
force-pushed
the
feat/waku-discovery
branch
from
961ce83 to
a1d9e34
Compare
|
|
||
| // Peer Exchange Discovery | ||
| export { | ||
| wakuPeerExchange, |
There was a problem hiding this comment.
Wondering if we need these waku*. To me it seems we can avoid and just be straight - peerExchangeDiscovery, peerCacheDiscovery, etc
There was a problem hiding this comment.
Removed two exports, but we use reft of them somewhere or the other (mostly for different types of tests)
Please feel free to take a look and suggest if there's an unnecessary export remaining
| // dynamically importing the local storage polyfill for node | ||
| if (typeof window === "undefined") { | ||
| try { | ||
| const { LocalStorage } = await import("node-localstorage"); |
There was a problem hiding this comment.
it's only needed for tests so another check can be used too, for example
js-waku/packages/sdk/src/utils/libp2p.ts
Line 40 in fb41f4c
There was a problem hiding this comment.
typeof window check feels more robust for karma compilation purposes: karma can't compile node packges, thus this acts as a good safe guard.
Is this a nit? can also try with the NODE_ENV flag
Thanks for the comments! Addressed :) |
danisharora099
force-pushed
the
feat/waku-discovery
branch
from
0fad331 to
c2e3a8e
Compare
| @@ -6,5 +6,5 @@ | |||
| "tsBuildInfoFile": "dist/.tsbuildinfo" | |||
| }, | |||
| "include": ["src"], | |||
| "exclude": ["src/**/*.spec.ts", "src/test_utils"] | |||
There was a problem hiding this comment.
src/test_utils isn't actually any directory in this package. seems to have come in during a copy. spec.ts files are still excluded
danisharora099
force-pushed
the
feat/waku-discovery
branch
from
56956d4 to
4e6dca7
Compare
Problem
We currently have 3 discovery options available within Waku:
For this, we have 3 separate packages, which might only increase with time.
Solution
Create a generalised package
@waku/discoveryto encapsulate all the available discovery mechanisms.Notes
@waku/discoveryto encapsulate all discovery mechanisms available within Waku #1862