-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable release-please & add it to CI #1155
Conversation
@@ -0,0 +1,11 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed as starting point to create next versions. Description
@@ -0,0 +1,18 @@ | |||
{ | |||
"bootstrap-sha": "13183350fac680be8c0e89ca3dc3951330b8b7c0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intentionally defined properties with default valued because they might be used by someone later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw it is a hash of a commit (not including) from which it will make next release
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another concern I have is around changelog management.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weboko. I guess this does not handle changelog at all, what are you thoughts on managing changelog?
@fryorcraken changelog is automatically updated based on commits. |
@weboko last remaining question: are we able to do patch increment only? |
Right now it should be patch only. |
@weboko does it mean it releases for any change? or it only release for feat/fix ? @weboko @danisharora099 I propose to make PR approval mandatory from this PR because it now directly release. Today we only patch increment but once we do minor and patch increment, we'll need a second pair of eye to ensure that we mark PR as breaking API when they do. Nothing worse than a lib with a patch bump that breaks backward compatibility. WDYT? |
I agree, but in case a mistake will be made - we still can fix it in a release PR created by the bot. |
Problem
Right now it takes some time to make a release of
@waku/*
packages and it is mostly manual work that blocks other devs.Solution
Considering different approaches
release-please
is the most convenient one.Example of an automated PR for next release: #1157
Notes
Default mapping is used:
https://git.io/JqCZL
Description of config:
https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md