Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release bump patch only #1173

Merged
merged 2 commits into from
Feb 11, 2023
Merged

chore: release bump patch only #1173

merged 2 commits into from
Feb 11, 2023

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Feb 11, 2023

Follow up to release-please config to bump only patch.

Solution is to use valid property which is not well documented - googleapis/release-please@8a7bfc1#diff-545bcd69c10300cbce0642d6970d8ccbff666d1e2b70b048084d4c6ec8b1e3d7

Example of release PR: #1175
Previous PR to #1155

@weboko weboko requested a review from fryorcraken as a code owner February 11, 2023 18:58
@github-actions
Copy link

github-actions bot commented Feb 11, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku core 115.03 KB (0%) 2.4 s (0%) 2.7 s (-14.89% 🔽) 5 s
Waku default setup 386.85 KB (0%) 7.8 s (0%) 5.8 s (-14.2% 🔽) 13.5 s
ECIES encryption 27.88 KB (0%) 558 ms (0%) 1.8 s (+103.03% 🔺) 2.3 s
Symmetric encryption 27.88 KB (0%) 558 ms (0%) 1.8 s (+36.79% 🔺) 2.4 s
DNS discovery 108.8 KB (0%) 2.2 s (0%) 3 s (-2.15% 🔽) 5.2 s
Privacy preserving protocols 114.05 KB (0%) 2.3 s (0%) 2.7 s (+11.8% 🔺) 5 s
Light protocols 116.11 KB (0%) 2.4 s (0%) 3 s (+13.88% 🔺) 5.3 s
History retrieval protocols 115.95 KB (0%) 2.4 s (0%) 1.9 s (-14.81% 🔽) 4.2 s

@weboko weboko changed the title chore: bump minor instead of major chore: release bump patch only Feb 11, 2023
@weboko weboko merged commit 596c71a into master Feb 11, 2023
@weboko weboko deleted the weboko/fix-release branch February 11, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant