-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adding new job in the CI.yml file #3193
Open
AYAHASSAN287
wants to merge
33
commits into
master
Choose a base branch
from
QA_temp_branch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 23 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
77e2eb3
Adding new job in the CI.yml file
AYAHASSAN287 b0d85b3
edit yml file name
AYAHASSAN287 62780c3
retrigger PR
AYAHASSAN287 dacc5fb
trigger PR
AYAHASSAN287 5589bbf
remove dependency to speed up job
AYAHASSAN287 a61327c
trigger PR
AYAHASSAN287 3ac4789
clone waku test repo
AYAHASSAN287 8f084c5
clone QA test repo
AYAHASSAN287 5f9a974
remove secrets and add path
AYAHASSAN287 199b126
Add runs-on
AYAHASSAN287 c708f1d
remove steps
AYAHASSAN287 f66506a
Adding repo name in checkout
AYAHASSAN287 ed9dd23
use yml of smoke_tests branch
AYAHASSAN287 96c5708
trigger CI job
AYAHASSAN287 461f6d3
trigger CI job
AYAHASSAN287 6213338
trigger PR
AYAHASSAN287 0d62121
pass image as input to yml file
AYAHASSAN287 ff784be
trigger PR
AYAHASSAN287 5fc922a
trigger PR
AYAHASSAN287 d3f0275
Change node1 name
AYAHASSAN287 a9872d5
trigger PR
AYAHASSAN287 2e44434
Change yml file name
AYAHASSAN287 2a5bff9
removing runs-on
AYAHASSAN287 d099b83
Change branch to master
AYAHASSAN287 35c6d33
change branch to master
AYAHASSAN287 7cfbcc1
Checkout on tag instead of master
AYAHASSAN287 953a3e6
Change job name to nwaku-nwaku-interop-tests
AYAHASSAN287 16eabe8
Test checkout on tag instead of master
AYAHASSAN287 143f1a5
checkout on master
AYAHASSAN287 05d8f2f
Check on tag name
AYAHASSAN287 b4b8acc
add ref tag name in yml file
AYAHASSAN287 26f8c3c
revert change of checkout on tag
AYAHASSAN287 c26629e
Merge branch 'master' into QA_temp_branch
AYAHASSAN287 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -126,6 +126,15 @@ jobs: | |
uses: waku-org/nwaku/.github/workflows/container-image.yml@master | ||
secrets: inherit | ||
|
||
QA_tests: | ||
needs: build-docker-image | ||
uses: waku-org/waku-interop-tests/.github/workflows/nim_waku_PR.yml@smoke_tests | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please don't forget to update the branch when the interop PR get's merged to master There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
with: | ||
node_nwaku: ${{ needs.build-docker-image.outputs.image }} | ||
|
||
secrets: inherit | ||
|
||
|
||
js-waku-node: | ||
needs: build-docker-image | ||
uses: waku-org/js-waku/.github/workflows/test-node.yml@master | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's name it somthing more suggestive, ex:
nwaku-nwaku-interop-tests
because we will also have at some point
nwaku-gowaku-interop-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done