chore: adding new job in the CI.yml file #3193
Conversation
|
You can find the image built from this PR at Built from 55624ea |
.github/workflows/ci.yml
Outdated
| @@ -126,6 +126,15 @@ jobs: | |||
| uses: waku-org/nwaku/.github/workflows/container-image.yml@master | |||
| secrets: inherit | |||
|
|
|||
| QA_tests: | |||
There was a problem hiding this comment.
let's name it somthing more suggestive, ex:
nwaku-nwaku-interop-tests
because we will also have at some point
nwaku-gowaku-interop-tests
.github/workflows/ci.yml
Outdated
| @@ -126,6 +126,15 @@ jobs: | |||
| uses: waku-org/nwaku/.github/workflows/container-image.yml@master | |||
| secrets: inherit | |||
|
|
|||
| QA_tests: | |||
| needs: build-docker-image | |||
| uses: waku-org/waku-interop-tests/.github/workflows/nim_waku_PR.yml@smoke_tests | |||
There was a problem hiding this comment.
please don't forget to update the branch when the interop PR get's merged to master
Ivansete-status
changed the title
|
@AYAHASSAN287 : Please add one or more reviewers from nwaku team. We need at least two approval to be able to merge. |
.github/workflows/ci.yml
Outdated
| @@ -126,6 +126,15 @@ jobs: | |||
| uses: waku-org/nwaku/.github/workflows/container-image.yml@master | |||
| secrets: inherit | |||
|
|
|||
| QA_tests: | |||
| needs: build-docker-image | |||
| uses: waku-org/waku-interop-tests/.github/workflows/nim_waku_PR.yml@master | |||
There was a problem hiding this comment.
Instead of using master I think it is better to use a fixed tag so that the changes in your master doesn't impact our CI :)
There was a problem hiding this comment.
Thanks @AYAHASSAN287!
Nevertheless, I see the master is being used
uses: waku-org/waku-interop-tests/.github/workflows/nim_waku_PR.yml@master
What do you mean by "done" :) ?
There was a problem hiding this comment.
Checkout on the tag"SMOKE_TESTS" is done inside the yml file invoked in interop-test repo .
Latest job was triggered to test that checkout is done successfully on the tag
Ivansete-status
requested review from
darshankabariya,
gabrielmer and
NagyZoltanPeter
.github/workflows/ci.yml
Outdated
| @@ -126,6 +126,15 @@ jobs: | |||
| uses: waku-org/nwaku/.github/workflows/container-image.yml@master | |||
| secrets: inherit | |||
|
|
|||
| nwaku-nwaku-interop-tests: | |||
| needs: build-docker-image | |||
| uses: waku-org/waku-interop-tests/.github/workflows/nim_waku_PR.yml@SMOKE_TESTS | |||
There was a problem hiding this comment.
do we have such branch on waku-interop-tests side?
There was a problem hiding this comment.
changed to master now
.github/workflows/ci.yml
Outdated
| @@ -128,7 +128,7 @@ jobs: | |||
|
|
|||
| nwaku-nwaku-interop-tests: | |||
| needs: build-docker-image | |||
| uses: waku-org/waku-interop-tests/.github/workflows/nim_waku_PR.yml@SMOKE_TESTS | |||
| uses: waku-org/waku-interop-tests/.github/workflows/nim_waku_PR.yml@smoke_tests_review | |||
There was a problem hiding this comment.
I guess it should be SMOKE_TESTS
There was a problem hiding this comment.
tag name is added in waku_interop_tests repo at file test_PR_image.yml
Description
This PR contains adding new job nwaku-nwaku-interop-tests .
The job fetches yml file nim_waku_PR.yml at tag SMOKE_TEST_0.0.1 to run set of tests "smoke tests "
from waku-test-repo
Changes