-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adding new job in the CI.yml file #3193
base: master
Are you sure you want to change the base?
Changes from 25 commits
77e2eb3
b0d85b3
62780c3
dacc5fb
5589bbf
a61327c
3ac4789
8f084c5
5f9a974
199b126
c708f1d
f66506a
ed9dd23
96c5708
461f6d3
6213338
0d62121
ff784be
5fc922a
d3f0275
a9872d5
2e44434
2a5bff9
d099b83
35c6d33
7cfbcc1
953a3e6
16eabe8
143f1a5
05d8f2f
b4b8acc
26f8c3c
c26629e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -126,6 +126,15 @@ jobs: | |
uses: waku-org/nwaku/.github/workflows/container-image.yml@master | ||
secrets: inherit | ||
|
||
QA_tests: | ||
needs: build-docker-image | ||
uses: waku-org/waku-interop-tests/.github/workflows/nim_waku_PR.yml@master | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of using There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks @AYAHASSAN287! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Checkout on the tag"SMOKE_TESTS" is done inside the yml file invoked in interop-test repo . Latest job was triggered to test that checkout is done successfully on the tag |
||
with: | ||
node_nwaku: ${{ needs.build-docker-image.outputs.image }} | ||
|
||
secrets: inherit | ||
|
||
|
||
js-waku-node: | ||
needs: build-docker-image | ||
uses: waku-org/js-waku/.github/workflows/test-node.yml@master | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's name it somthing more suggestive, ex:
nwaku-nwaku-interop-tests
because we will also have at some point
nwaku-gowaku-interop-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done