Update WakuStoreCodec string to beta4 #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staheri14
reviewed
Feb 17, 2022
CHANGELOG.md
Outdated
| @@ -15,6 +15,7 @@ The full list of changes is below. | |||
|
|
|||
| - A new type `Timestamp` for all timestamps is introduced (currently an alias for int64). | |||
| - All timestamps now have nanosecond resolution. | |||
| - `waku-store` version updated to `2.0.0-beta3` | |||
There was a problem hiding this comment.
Suggested change
| - `waku-store` version updated to `2.0.0-beta3` | |
| - `waku-store` protocol identifier is updated to `/vac/waku/store/2.0.0-beta4` |
staheri14
reviewed
Feb 17, 2022
waku/v2/node/wakunode2.nim
Outdated
| @@ -97,7 +97,7 @@ proc protocolMatcher(codec: string): Matcher = | |||
| proc match(proto: string): bool {.gcsafe.} = | |||
| ## Matches a proto with any postfix to the provided codec. | |||
| ## E.g. if the codec is `/vac/waku/filter/2.0.0` it matches the protos: | |||
| ## `/vac/waku/filter/2.0.0`, `/vac/waku/filter/2.0.0-beta3`, `/vac/waku/filter/2.0.0-actualnonsense` | |||
| ## `/vac/waku/filter/2.0.0`, `/vac/waku/filter/2.0.0-beta4`, `/vac/waku/filter/2.0.0-actualnonsense` | |||
There was a problem hiding this comment.
The filter protocol is not updated
staheri14
reviewed
Feb 18, 2022
CHANGELOG.md
Outdated
| @@ -15,6 +15,7 @@ The full list of changes is below. | |||
|
|
|||
| - A new type `Timestamp` for all timestamps is introduced (currently an alias for int64). | |||
| - All timestamps now have nanosecond resolution. | |||
| - `waku-store` version updated to `2.0.0-beta4` | |||
There was a problem hiding this comment.
Suggested change
| - `waku-store` version updated to `2.0.0-beta4` | |
| - `waku-store` protocol identifier is updated to `/vac/waku/store/2.0.0-beta4` |
Jenkins BuildsClick to see older builds (6)
|
D4nte
approved these changes
Feb 18, 2022
oskarth
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light of the store protocol update provided by #842 (timestamps now have nanosecond resolution), the
WakuStoreCodecstring inwaku_storeneeds to be updated to the most recent version-beta4in order to be aligned to the corresponding RFC https://rfc.vac.dev/spec/13/.