Refactoring & some features

[di72nn]

I started fixing bad fields usage in QueueItem, one thing led to another, and it seems I'm fixing #880 (I actually did, but there's still a lot of redundancy to remove).

The PR includes #930, but I'll leave it be for the time being.

I'll add some explanation later.

[di72nn]

Time for some details.

As was mentioned in #930, the use of generic fields is not exactly obvious. Unfortunately, greenDAO doesn't support entity inheritance, so I added (6779550) "view" classes that encapsulate operation-specific logic and provide better API to the QueueItem users. I left generic fields (in QueueItem and DB) as is, but they are not for direct use anymore.

I wanted to deal with similar problem in ActionRequest, but it required more changes, so the rewriting commenced.

One of the most prominent mistake I made when I originally wrote all that offline synchronization stuff was that some DB writing was still happening in the main (UI) thread (#880). Even if the operations are tiny, they get stuck if there are other background writes (background sync, etc.) for the whole duration of those background transactions.
Those long operations should be shortened of course (like doing the sync in a bunch of short transactions), but I'll leave it for another day. It won't solve the problem completely anyway.

So I decided to move all DB writing from UI. Most of the operations can be scheduled using serializableparcelable objects with a simple IntentService, but arguments to some operations (like updating article tags and annotations) are a real pain to make parcelable. Turns out it is possible to pass non-parcelable objects to a bound service. So a TaskService was born - a hybrid of a "started" service (lifecycle doesn't depend on clients) and a "bound" service (allows method calls with non-parcelable parameters).

A lot of refactoring followed: implementation of better parcelable tasks and move of the majority of old operations to these tasks, splitting of old services into separate classes and some other stuff.

I also rewrote "offline queue" optimization: previously it was removing/merging related changes during addition to queue, now it is done during queue sync. This allows to add new queue items even if there's a sync in progress (new items won't be processed right away, but neither they'll break anything). This also removed a lot of code duplication.

The codebase still leaves a lot to be desired, but it's way better than before (for one, you can follow an operation from its entry point (in OperationsHelper) to the code that carries out the operation without having any detours to the task execution code).

Oh, there's one problem though: the changes may be delayed. For example, if there's a long sync in the background and a user marks an article as favorite and then presses "mark as read", in the lists the article will still appear neither favorited nor read until the background operation is finished. Still an improvement over ANR. Improving long operations should help.

I plan to do some more changes, but everything should be already working.

[di72nn]

@tcitworld can you shed some light on release plans? It is problematic to write new stuff when older changes weren't even beta tested.

[tcitworld]

@tcitworld can you shed some light on release plans? It is problematic to write new stuff when older changes weren't even beta tested.

Unfortunately there's been nearly no activity lately, apart from @Kdecherf, so no idea. https://app.wallabag.it is running on master though.

[di72nn]

I meant the android app release plans.

[di72nn]

Added a dialog that appears when a url is shared to wallabag app. The dialog allows to tag, favorite and archive an article right after it was added (even offline). Fixes #675.
Also allows to open the added article (but only after it gets synced in background). Fixes #868.

[di72nn]

Tags in article view (clickable). Fixes #464.
<untagged> entry in tag list to see untagged articles. Fixes #547.
Context menu for article lists (non-bulk only). Fixes #233.

[di72nn]

Pushed a separate branch with TTS-related refactoring. Not sure how stable it is yet.
TTS is in a separate PR: #945.

[tcitworld]

@di72nn Please rebase and then we'll get this in.

[di72nn]

@tcitworld there's a lot of changes in the master already, can you release a beta? It would be great to have a release before merging this.

[tcitworld]

okay let's try this

[di72nn]

Moved all the commits from #945 here, because it's effectively the same PR now.

[di72nn]

GPlay Console shows 107 "installs on active devices" for the latest beta, and no new crashes.

@tcitworld I think this PR is ready for another beta.

[di72nn]

Updated some minor things. Sorry for all this history-rewriting noise - I figure it's better to fix things right where they were introduced.

[Strubbl]

So far the app works as expected in my daily usage. TTS not tested yet.

[di72nn]

@tcitworld any news on the review?