-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of TTS #945
Refactoring of TTS #945
Conversation
Inline elements are no longer separate text units. |
Add rudimentary "emphasizing" for bold/strong/italic text. I didn't find any way to make Android TTS emphasize parts of text, so I just add commas around these emphasized parts to denote them with pauses. I'm not happy with the amount of code (and its complexity) it takes, but oh well. Also made TTS pronounce alt text or title of images. |
a13f503
to
eff21ef
Compare
Don't reset reading position if scrolling didn't change since pause (fixes #939 as a third option described here). Fixed TTS notification icon: a wallabag logo is now displayed instead of a solid square. |
Tested on Android 5 emulator
Also extract action strings
Also fix a foreground service-related crash
b77fbeb
to
3cbb437
Compare
363a279
to
4883388
Compare
A separate PR for TTS. Based on #931.
I tried to improve code and fix potential synchronization issues while keeping the logic mostly intact (except some initialization stages - those had to be changed because TTS didn't work for me).
It is still far from perfect, but that should do for now.
So far I only tested it a bit with Google TTS on an Android 9 emulator and a LineageOS 16 device.
I may make some more improvements, but no promises.
Outstanding issues (in general, not in this PR):
the U.S. and
(it basically splits by any.
,?
,!
followed by a space).@tyndare here are the latest changes in case you want to give it a go. Please comment if you do.