Merge pull request #171 from Rincelent/memory-leak-select

Fixed a memory leak on Select widget
wanadev · Mar 31, 2023 · 7ddc215 · 7ddc215
2 parents d28513c + 2c013f9
commit 7ddc215
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/src/composite/select.js b/src/composite/select.js
@@ -114,9 +114,12 @@ var Select = Widget.$extend({
         }
 
         this._value = "";
-        var item = new MenuItem({text: this.placeholder, className: "photonui-select-placeholder"});
+        if (this.__displayValue) {
+            this.__displayValue.destroy();
+        }
+        this.__displayValue = new MenuItem({text: this.placeholder, className: "photonui-select-placeholder"});
         Helpers.cleanNode(this.__html.select);
-        this.__html.select.appendChild(item.html);
+        this.__html.select.appendChild(this.__displayValue.html);
     },
 
     /**
@@ -325,7 +328,12 @@ var Select = Widget.$extend({
      * @method destroy
      */
     destroy: function () {
-        this.__popupMenu.destroy();
+        if (this.__displayValue) {
+            this.__displayValue.destroy();
+        }
+        if (this.__popupMenu) {
+            this.__popupMenu.destroy();
+        }
         this.$super();
     },