Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak select #171

Merged
merged 9 commits into from
Mar 31, 2023
Merged

Memory leak select #171

merged 9 commits into from
Mar 31, 2023

Conversation

Rincelent
Copy link
Contributor

Correct a small memory leak happening when destroying select widget

Rincelent and others added 6 commits February 1, 2022 14:25
Mouse move event  as always button === 0  event  when dragigng with right click-press . 
Therefore this._button need to be updated
Co-authored-by: Thomas Fromont <tomstom-du-01@hotmail.fr>
Call the destroy function of the child node.
Add missing ;
@flozz flozz changed the base branch from master to develop March 31, 2023 09:33
@flozz
Copy link
Member

flozz commented Mar 31, 2023

The changes looks good so far. There is only some coding style issue:

$ grunt jshint
Running "jshint:all" (jshint) task

   src/composite/select.js
    117 |        if (this.__displayValue) this.__displayValue.destroy();
                                          ^ Expected '{' and instead saw 'this'.
    329 |        if (this.__displayValue) this.__displayValue.destroy();
                                          ^ Expected '{' and instead saw 'this'.
    330 |        if (this.__popupMenu) this.__popupMenu.destroy();
                                       ^ Expected '{' and instead saw 'this'.

>> 3 errors in 54 files

@flozz flozz merged commit 7ddc215 into wanadev:develop Mar 31, 2023
@flozz
Copy link
Member

flozz commented Mar 31, 2023

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants