feat: add warp ds eslint config #238
Conversation
|
…act, warp and prettier + fix linting issues
vite.config.js
Outdated
| "build.js", | ||
| "esbuild.js", | ||
| ], | ||
| exclude: ['**.json', 'dev/**', 'storybook-static/**', '.storybook/**', 'packages/**/stories', 'packages/**/src/locales', 'esbuild.mjs', 'lingui.config.ts', '@types', 'tests/', 'packages/**/src/props.*', 'packages/**/src/index.*', 'packages/index.ts', 'build.js', 'esbuild.js'], |
There was a problem hiding this comment.
I can't wrap my head around why this wrapped content was formated to be one line, while in other repos that didn't happen. We had the same setup e.g. in @warp-ds/vue, which extends @warp-ds/eslint-config. I see that in our Warp config we specified printWidth for prettier to 999 (code), which sounds like the setting responsible for this, but it only seems to apply in this repo. I'm also wondering, is printWidth: 999 rule for prettier something we would like to have? @warp-ds/warp-core-team
There was a problem hiding this comment.
Yeah I don't know why it didn't format the same way as for vue 🙈 😕
There was a problem hiding this comment.
It shouldn't exceed 140 "printWidth": 140,
This would work on most retina display macbooks without issues
There was a problem hiding this comment.
It also might be because of "plugin:prettier/recommended" in the eslintrc 🤔
There was a problem hiding this comment.
No it did that formatting before I added "plugin:prettier/recommended" in the eslintrc
There was a problem hiding this comment.
Although it looks like it had formatted the exclude array the same way in the vite.config.jsfile for vue. 🤔 See here
There was a problem hiding this comment.
Isn't it the "printWidth": 999 from @warp-ds/eslint-config that is kicking in here (and then it didn't in the other repos?)? When I added printWidth: 150 as a separate rule in .eslintrc here, it worked fine. 999 characters is an eternity in the world of an IDE, so I'm not sure why it was set to that in the first place 😅
There was a problem hiding this comment.
But it reacted the same way in vue as in react (see my previous comment). So it did kick in. Talked to @imprashast and we talked about that I should update the @warp-ds/eslint-config to have printWidth: 140 :)
.github/workflows/lint.pr.yaml
Outdated
| - name: Install pnpm and dependencies | ||
| uses: pnpm/action-setup@v2 | ||
| with: | ||
| version: 8 |
There was a problem hiding this comment.
| version: 8 | |
| version: 9 |
There was a problem hiding this comment.
Ah good catch!
# [1.6.0-next.1](v1.5.0...v1.6.0-next.1) (2024-05-16) ### Features * add warp ds eslint config ([#238](#238)) ([d83f799](d83f799))
# [1.6.0](v1.5.0...v1.6.0) (2024-07-03) ### Bug Fixes * add default targetEl for callout ([#248](#248)) ([e297880](e297880)) * bump core to fix slider ([#250](#250)) ([5192147](5192147)) * **slider:** Prevent onChange/onChangeAfter called on mount ([#253](#253)) ([84ddd64](84ddd64)) ### Features * add warp ds eslint config ([#238](#238)) ([d83f799](d83f799)) * slider onChangeAfter prop ([#247](#247)) ([fa1af5c](fa1af5c)) * **toggle:** add ReactNode type to toggle labels ([#244](#244)) ([abeff99](abeff99))
Fixes Jira issue: WARP-520
pnpm lint