fix: add default targetEl for callout #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is done before recompute useEffect
|
felicia-haggqvist
changed the title
felicia-haggqvist
changed the title
imprashast
reviewed
Jun 14, 2024
packages/attention/src/component.tsx
Outdated
| @@ -92,7 +93,7 @@ export function Attention(props: AttentionProps) { | |||
| attentionEl.current = v; | |||
| }, | |||
| get targetEl() { | |||
| return targetEl?.current; | |||
| return targetElRef.current; | |||
There was a problem hiding this comment.
targetElRef can be null so maybe do targetElRef?.current just so the null is handled
There was a problem hiding this comment.
Ah good catch! 👍
imprashast
reviewed
Jun 14, 2024
tests/components/TextAreaTest.tsx
Outdated
| @@ -126,6 +126,7 @@ describe('TextArea component', () => { | |||
| const textAreaRef = createRef<HTMLTextAreaElement>(); | |||
|
|
|||
| // Render the TextArea component and pass the ref as forwardRef | |||
| // eslint-disable-next-line no-unused-vars | |||
| const { container } = render(<TextArea ref={textAreaRef} />); | |||
There was a problem hiding this comment.
This could just be (without the eslint-disable):
// Render the TextArea component and pass the ref as forwardRef
render(<TextArea ref={textAreaRef} />);
imprashast
approved these changes
Jun 14, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
# [1.6.0-next.4](v1.6.0-next.3...v1.6.0-next.4) (2024-06-17) ### Bug Fixes * add default targetEl for callout ([#248](#248)) ([e297880](e297880))
github-actions bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
# [1.6.0](v1.5.0...v1.6.0) (2024-07-03) ### Bug Fixes * add default targetEl for callout ([#248](#248)) ([e297880](e297880)) * bump core to fix slider ([#250](#250)) ([5192147](5192147)) * **slider:** Prevent onChange/onChangeAfter called on mount ([#253](#253)) ([84ddd64](84ddd64)) ### Features * add warp ds eslint config ([#238](#238)) ([d83f799](d83f799)) * slider onChangeAfter prop ([#247](#247)) ([fa1af5c](fa1af5c)) * **toggle:** add ReactNode type to toggle labels ([#244](#244)) ([abeff99](abeff99))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Jira WARP-527
targetElwhencalloutistrueandtargetElisundefined.targetEl:"useAutoUpdatePosition hook is using @warp-ds/core, which uses Floating-ui's computePosition(). Floating-ui's computePosition() requires a defined targetEl to be able to compute the attentionEl's position and the attentionEl's arrow position. When props.callout is true, we only need computePosition() to calculate the callout's arrow position. So, we create a default targetEl for callout that we can pass to the useAutoUpdatePosition hook, in order to avoid Floating-ui from throwing an error."ml-8to the callout stories.Tested: