fix: add start end suffix for callout and add eslint-config #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve computeCalloutArrow
…ch component-library
felicia-haggqvist
changed the title
This was referenced Jun 11, 2024
imprashast
approved these changes
Jun 11, 2024
felicia-haggqvist
deleted the
fix/add-start-end-placement-support-callout
branch
github-actions bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
## [1.1.2](v1.1.1...v1.1.2) (2024-06-12) ### Bug Fixes * add start end suffix for callout and add eslint-config ([#17](#17)) ([605fbc6](605fbc6))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Jira WARP-527
Add @warp-ds/eslint-config as a devDependency
Add linting scripts to package.json
Lint all code using
pnpm lintAdd github workflow for linting PR.
Remove
middlePosition,isDirectionVerticalandcomputeCalloutArrow()and compute callout's arrow position in thecomputePosition()instead.Add a check to only apply
leftandtopstyle toattentionElwhenisCalloutisfalse, since we only want to use Floating-ui'scomputePosition()to calculate the callout's arrow position and not the attention element's position, due to thattargetElcan be undefined whenisCalloutistrue.How to test:
fix/add-start-end-suffix-calloutin @warp-ds/react, @warp-ds/vue and/or @warp-ds/elements