fix: add default targetEl for callout #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o avoid ssr error regarding document being undefined
felicia-haggqvist
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
## [2.0.1-next.3](v2.0.1-next.2...v2.0.1-next.3) (2024-06-17) ### Bug Fixes * add default targetEl for callout ([#170](#170)) ([957e4cb](957e4cb))
github-actions bot
pushed a commit
that referenced
this pull request
Jul 4, 2024
## [2.0.1](v2.0.0...v2.0.1) (2024-07-04) ### Bug Fixes * add default targetEl for callout ([#170](#170)) ([957e4cb](957e4cb)) * add support for formatting vue files ([#167](#167)) ([347ab79](347ab79)) * Deprecate the "notification" variant of Badge ([#172](#172)) ([74bf5f2](74bf5f2)) * revert renaming key in w-toggle ([#168](#168)) ([286ed74](286ed74))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Jira WARP-527
targetElwhencalloutistrueandtargetElisundefined.targetEl:"the autoUpdatePosition() from @warp-ds/core, uses Floating-ui's computePosition(). Floating-ui's computePosition() requires a defined targetEl to be able to compute the attentionEl's position and the attentionEl's arrow position. When props.callout is true, we only need computePosition() to calculate the callout's arrow position. So, we create a default targetEl for callout that we can pass to the autoUpdatePosition(), in order to avoid Floating-ui from throwing an error."Tested: