Add rule to check file name of SLS files #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new rule to check file name of SLS files, as SLS file with a period in the name (besides the suffix period) can not be referenced. This commit also allows rules to only run for specific file types by adding valid `languages` to the rule. File types are determined based upon the file extension. Fixes warpnet#205 Signed-off-by: Roald Nefs <info@roaldnefs.com>
Signed-off-by: Roald Nefs <info@roaldnefs.com>
jbouter
approved these changes
Nov 29, 2020
|
Code has been tested and works |
jbouter
pushed a commit
that referenced
this pull request
Jan 17, 2021
Version 0.5.0 release. Besides bumping the version this commit also includes the following changes: - Separate the ansible-lint license. - Update changelog to include all changes for v0.5.0. - Remove duplicate documentation (code of conduct). - Add already existing documentation to the Sphinx documentation. - Add additional badges to the README.md. - Simplify and update the GitHub Workflow to release to PyPi. - Updated the `version_added` in all new rules. - Ignore docs directory for linting tests - Disable markdownlint as it breaks the GitHub workflow - Add link to dense-analysis/ale vim plugin in README - Update supported Python version to include newer Python versions. - Fix some code style issues found by flake 8. - Add .j2 as Jinja file extension - Use tox and pre-commit for testing Changelog: Rule 213 to recommend using cmd.run together with onchanges (#207). Rule 214 to check SLS file with a period in the name (besides the suffix period) as they can not be referenced by Salt (#209). Rules 901-915 to check for deprecated states and state options (#214). This CHANGELOG.md file to be able to list all notable changes for each version of salt-lint (#223). Signed-off-by: Roald Nefs <info@roaldnefs.com> Co-authored-by: Benjamin <poulpatine@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new rule to check file name of SLS files, as SLS file with a period
in the name (besides the suffix period) can not be referenced.
This pull request also allows rules to only run for specific file types by
adding valid
languagesto the rule. File types are determined basedupon the file extension.
Fixes #205