Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new deprecation functionality #214

Merged
merged 5 commits into from
Dec 9, 2020

Conversation

jbouter
Copy link
Member

@jbouter jbouter commented Dec 4, 2020

  • Add DeprecationRule function
  • Add new deprecation rules
  • Unit tests still need to be written

Fixes #204

- Add DeprecationRule function
- Add new deprecation rules
- Unit tests still need to be written
@jbouter jbouter requested a review from roaldnefs December 4, 2020 16:21
Signed-off-by: Roald Nefs <info@roaldnefs.com>
Signed-off-by: Roald Nefs <info@roaldnefs.com>
Signed-off-by: Roald Nefs <info@roaldnefs.com>
Signed-off-by: Roald Nefs <info@roaldnefs.com>
@roaldnefs roaldnefs changed the title WIP: Add new deprecation functionality Add new deprecation functionality Dec 8, 2020
@roaldnefs roaldnefs changed the base branch from main to develop December 8, 2020 20:19
@roaldnefs roaldnefs added Priority: Low Type: Enhancement New feature or request labels Dec 8, 2020
@jbouter jbouter merged commit a6fb8a9 into warpnet:develop Dec 9, 2020
@jbouter jbouter deleted the add-deprecation-rules branch December 9, 2020 13:30
jbouter pushed a commit that referenced this pull request Jan 17, 2021
Version 0.5.0 release. Besides bumping the version this commit also
includes the following changes:

- Separate the ansible-lint license.
- Update changelog to include all changes for v0.5.0.
- Remove duplicate documentation (code of conduct).
- Add already existing documentation to the Sphinx documentation.
- Add additional badges to the README.md.
- Simplify and update the GitHub Workflow to release to PyPi.
- Updated the `version_added` in all new rules.
- Ignore docs directory for linting tests
- Disable markdownlint as it breaks the GitHub workflow
- Add link to dense-analysis/ale vim plugin in README
- Update supported Python version to include newer Python versions.
- Fix some code style issues found by flake 8.
- Add .j2 as Jinja file extension
- Use tox and pre-commit for testing

Changelog: 
Rule 213 to recommend using cmd.run together with onchanges (#207).
Rule 214 to check SLS file with a period in the name (besides the suffix period) as they can not be referenced by Salt (#209).
Rules 901-915 to check for deprecated states and state options (#214).
This CHANGELOG.md file to be able to list all notable changes for each version of salt-lint (#223).

Signed-off-by: Roald Nefs <info@roaldnefs.com>

Co-authored-by: Benjamin <poulpatine@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Check state deprecation
2 participants