-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Go Package Index #354
Update Go Package Index #354
Conversation
142a354
to
328f642
Compare
328f642
to
9cfb071
Compare
I updated the readme with the version note and the documentation for some missing points. |
Please could you split these changes out into a separate PR? 😅 We now have a couple of PRs with large deltas and which just keep getting longer and longer. That makes it really tricky to review as it's not clear when a PR is "done", and we're ending up in endless cycles of comments as new stuff is being added all the time :) I think it'd help with review if we can keep them tightly scoped to a particular goal, even if that means we need to come back with more PRs in the future. |
18ae5fa
to
3dd525d
Compare
Moved the readme and documentation update to #376 |
I will try to rebase less during the review :) |
Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Warren gave a 👍 in the comments, I believe.
Thanks @MatrixCrawler for splitting the PR :)
This possibly fixes #192
We need to add a v in front of the versioning tags though