-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme and documentation update #376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two GIFs don't show for me eve nwhen downloaded. Is it me or them?
- https://github.com/warrensbox/terraform-switcher/blob/readme-doc-update/www/docs/static/contribute/tfswitch-workspace.gif
- https://github.com/warrensbox/terraform-switcher/blob/readme-doc-update/www/docs/static/versiontf.gif
Plus the whitespacing comments below.
Otherwise LGTM.
62fded5
to
c2e865d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few changes (hope you don't mind @MatrixCrawler 🙏) - this LGTM now.
I'll wait for @yermulnik to ✔️ too.
So are those GIFs "broken" for me only? #376 (review) |
2b55ffb
to
431bc63
Compare
Ah apologies - no, they are also broken for me. |
The issue seems to be git has converted line breaks incorrectly. See here. I've tried a few things but unfortunately cannot get git to accept the unconverted file, and |
@crablab Send me files via email and I'll see if I can add them correctly (I'm on Linux). |
So am I @yermulnik 🙂 I'll send them to you today. |
I think it might be becaus i forgot to add the *.gif as binary into the gitattributes so git changed the CLRF to LF |
2683f82
to
d0e6a5b
Compare
@crablab @yermulnik Fixed the gif files. |
Did some cleaning up with the readme and documentation