Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use smithy-bindgen to gen interface, re-export as 'testing' #24

Merged
merged 6 commits into from
Mar 23, 2023
Merged

use smithy-bindgen to gen interface, re-export as 'testing' #24

merged 6 commits into from
Mar 23, 2023

Conversation

stevelr
Copy link
Contributor

@stevelr stevelr commented Feb 20, 2023 •
edited
Loading

Feature or Problem

  • use smithy_bindgen to generate testing interface, re-export as testing
  • also clarifies namespace of TestResult to avoid ambiguity between internal and external

Related Issues

Waiting on wasmCloud/weld#143

Release Information

Consumer Impact

Acceptance or Integration

Manual Verification

Still testing w/ other crates

@stevelr
use smithy-bindgen to gen interface, re-export as 'testing'
d196bf1 
Signed-off-by: stevelr <steve@cosmonic.com>
@stevelr
minor cleanup
f1a2505 
Signed-off-by: stevelr <steve@cosmonic.com>
@stevelr
improve comments on result handling
8171ee4 
Signed-off-by: stevelr <steve@cosmonic.com>
@stevelr
Copy link
Contributor Author

stevelr commented Feb 22, 2023

Dependent on wasmCloud/weld#143

@stevelr stevelr mentioned this pull request Feb 22, 2023
Merged
@stevelr
Copy link
Contributor Author

stevelr commented Feb 22, 2023

Other than the references in Cargo.toml (which are blocked on other prs), this is ready for review

@stevelr stevelr marked this pull request as ready for review February 22, 2023 17:33
@stevelr @rvolosatovs
Update wasmcloud-test-util/src/lib.rs
1536328 
Co-authored-by: Roman Volosatovs <rvolosatovs@users.noreply.github.com>
@stevelr
Copy link
Contributor Author

stevelr commented Feb 28, 2023

This uses the new smithy-bindgen crate and the latest wasmbus-rpc. Bumped version to 0.7.0 since we now recommend that instead of importing wasmcloud-interface-testing, clients of this crate
use wasmcloud_test_util::testing instead.

@rvolosatovs
Copy link
Member

@stevelr looks like you need to amend 1536328 to include the sign-off for DCO

@stevelr
update dependencies, bump to 0.7.0
149875a 
Signed-off-by: stevelr <steve@cosmonic.com>
thomastaylor312
thomastaylor312 previously requested changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@thomastaylor312 thomastaylor312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes and a nit that is totally optional

wasmcloud-test-util/src/lib.rs Show resolved Hide resolved
wasmcloud-test-util/src/provider_test.rs Show resolved Hide resolved
@stevelr stevelr requested review from thomastaylor312 and removed request for rvolosatovs March 1, 2023 05:12
brooksmtownsend
brooksmtownsend reviewed Mar 6, 2023
View reviewed changes
Copy link
Member

@brooksmtownsend brooksmtownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this as long as @thomastaylor312 is 😄

@stevelr
add wasmcloud_test_util prefix inside macro
077dae2 
Signed-off-by: stevelr <steve@cosmonic.com>
@stevelr
Copy link
Contributor Author

stevelr commented Mar 23, 2023

@thomastaylor312 addressed your concern with 077dae2

@stevelr stevelr merged commit ead9510 into main Mar 23, 2023
@stevelr stevelr deleted the fix/bindgen branch March 23, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvolosatovs rvolosatovs rvolosatovs left review comments

@brooksmtownsend brooksmtownsend brooksmtownsend approved these changes

@thomastaylor312 thomastaylor312 Awaiting requested review from thomastaylor312

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevelr @rvolosatovs @thomastaylor312 @brooksmtownsend