Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/smithy bindgen #143

Closed
wants to merge 18 commits into from
Closed

Feat/smithy bindgen #143

wants to merge 18 commits into from

Conversation

stevelr
Copy link
Contributor

@stevelr stevelr commented Feb 20, 2023

Feature or Problem

New macro that performs inline code generation from smithy files, in the spirit of 'wit-bindgen'. Replaces nearly all uses of 'build.rs' and 'codegen.toml'.

Related Issues

n/a

Release Information

next

Consumer Impact

Does not affect existing code.

Unit Test(s)

unit tests in tests/ folder

Signed-off-by: stevelr <steve@cosmonic.com>
Signed-off-by: stevelr <steve@cosmonic.com>
Signed-off-by: stevelr <steve@cosmonic.com>
Signed-off-by: stevelr <steve@cosmonic.com>
Signed-off-by: stevelr <steve@cosmonic.com>
Signed-off-by: stevelr <steve@cosmonic.com>
Signed-off-by: stevelr <steve@cosmonic.com>
Signed-off-by: stevelr <steve@cosmonic.com>
Signed-off-by: stevelr <steve@cosmonic.com>
Signed-off-by: stevelr <steve@cosmonic.com>
Signed-off-by: stevelr <steve@cosmonic.com>
Signed-off-by: stevelr <steve@cosmonic.com>
Signed-off-by: stevelr <steve@cosmonic.com>
Copy link
Contributor

@thomastaylor312 thomastaylor312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is almost there. Just a few small things to fix

codegen/src/codegen_rust.rs Outdated Show resolved Hide resolved
codegen/src/docgen.rs Outdated Show resolved Hide resolved
codegen/Cargo.toml Outdated Show resolved Hide resolved
rpc-rs/Cargo.toml Outdated Show resolved Hide resolved
smithy-bindgen/README.md Outdated Show resolved Hide resolved
smithy-bindgen/tests/bindgen.rs Outdated Show resolved Hide resolved
Signed-off-by: stevelr <steve@cosmonic.com>
Signed-off-by: stevelr <steve@cosmonic.com>
Signed-off-by: stevelr <steve@cosmonic.com>
Signed-off-by: stevelr <steve@cosmonic.com>
@stevelr
Copy link
Contributor Author

stevelr commented Feb 28, 2023

merged already - closing this PR

@stevelr stevelr closed this Feb 28, 2023
@brooksmtownsend
Copy link
Member

@stevelr did this feature go through?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants