Support virtual memory usage on windows #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By doing so we add windows as a platform with support for virtual memory.
…memory-for-windows
This is basically what the code before the PR has been doing.
pepyakin
reviewed
Dec 8, 2021
athei
reviewed
Dec 9, 2021
This is yet another attempt at fixing the windows GHA CI
…memory-for-windows # Conflicts: # .github/workflows/rust.yml
athei
reviewed
Dec 9, 2021
athei
approved these changes
Dec 9, 2021
kpp
reviewed
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #200.
Summary
virtual_memorycrate feature enables cross-platform virtual memory on 64-bit platforms.Vec-based implementation. This has several reasons:mmapusage inwasmiis not expected to yield performance improvements due to a huge overhead with re-allocations and copying over all data upon agrowoperation.