Implement f{32,64}.copysign instructions #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
chfast
commented
Aug 11, 2020
•
chfast
commented
axic
reviewed
Aug 11, 2020
| @@ -1470,6 +1470,16 @@ ExecutionResult execute(Instance& instance, FuncIdx func_idx, span<const Value> | |||
| binary_op(stack, std::divides<float>{}); | |||
| break; | |||
| } | |||
| case Instr::f32_copysign: | |||
| { | |||
| // TODO: This is not optimal implementation. The std::copysign() is inlined, but | |||
There was a problem hiding this comment.
Why not implement it then? Is that planned after merging this? Did you only see this for copysign?
There was a problem hiding this comment.
Only for copysign and abs. Also theoretical UB will be involved, so I prefer to have all spec tests passed before doing that.
chfast
force-pushed
the
fp_div
branch
2 times, most recently
from
6435f60
to
717a89a
Compare
axic
reviewed
Aug 12, 2020
chfast
force-pushed
the
fp_div
branch
2 times, most recently
from
5636fa9
to
69fdd36
Compare
chfast
force-pushed
the
fp_copysign
branch
2 times, most recently
from
782518d
to
ef1f54c
Compare
Codecov Report
@@ Coverage Diff @@
## master #471 +/- ##
=======================================
Coverage 99.54% 99.54%
=======================================
Files 54 54
Lines 16324 16364 +40
=======================================
+ Hits 16250 16290 +40
Misses 74 74 |
axic
approved these changes
Aug 12, 2020
gumb0
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.