Implement f{32,64}.abs instructions #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gumb0
commented
Aug 12, 2020
•
gumb0
commented
gumb0
force-pushed
the
fabs
branch
3 times, most recently
from
3fc7b84
to
937faee
Compare
Codecov Report
@@ Coverage Diff @@
## master #476 +/- ##
=======================================
Coverage 99.53% 99.54%
=======================================
Files 54 54
Lines 16075 16123 +48
=======================================
+ Hits 16001 16049 +48
Misses 74 74 |
gumb0
force-pushed
the
fabs
branch
2 times, most recently
from
b51941f
to
66809d4
Compare
gumb0
commented
Aug 12, 2020
| @@ -1521,12 +1521,26 @@ ExecutionResult execute(Instance& instance, FuncIdx func_idx, span<const Value> | |||
| break; | |||
| } | |||
|
|
|||
| case Instr::f32_abs: | |||
| { | |||
| // TODO: This can be optimized https://godbolt.org/z/aPqvfo | |||
There was a problem hiding this comment.
Included link to the same goldbolt as in #471
gumb0
commented
Aug 12, 2020
| case Instr::f32_abs: | ||
| { | ||
| // TODO: This can be optimized https://godbolt.org/z/aPqvfo | ||
| unary_op(stack, static_cast<float (*)(float)>(std::fabs)); |
There was a problem hiding this comment.
std::fabs is unfortunately not a template, but several overloaded variants.
There was a problem hiding this comment.
(Also would work without casts: fabsf and fabs C functions.)
There was a problem hiding this comment.
(Also would work without casts:
fabsfandfabsC functions.)
That would only work for fabsf...
chfast
approved these changes
Aug 12, 2020
chfast
reviewed
Aug 12, 2020
| @@ -363,6 +385,27 @@ TYPED_TEST(execute_floating_point_types, add) | |||
| EXPECT_THAT(exec(TypeParam{0x0.287p2}, TypeParam{0x1.FFp4}), Result(TypeParam{0x1.048Ep5})); | |||
| } | |||
|
|
|||
| TYPED_TEST(execute_floating_point_types, abs) | |||
There was a problem hiding this comment.
Put the test by the opcode value, i.e. before add.
axic
approved these changes
Aug 12, 2020
chfast
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.