Call optimization #554
Closed
Call optimization #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased this locally on #562, much more easier to read it grouped with execute. |
axic
force-pushed
the
call_optimization
branch
from
c2d6235
to
e70c686
Compare
axic
reviewed
Oct 5, 2020
lib/fizzy/execute.cpp
Outdated
| assert(stack.size() >= num_args); | ||
| span<const Value> call_args{stack.rend() - num_args, num_args}; | ||
|
|
||
| const auto ret = execute(instance, func_idx, call_args.begin(), depth + 1); |
There was a problem hiding this comment.
Actually, why do we have both .data() and .begin() when they point to the same thing?
axic
force-pushed
the
call_optimization
branch
from
e70c686
to
e0d1d78
Compare
Codecov Report
@@ Coverage Diff @@
## master #554 +/- ##
=======================================
Coverage 98.25% 98.25%
=======================================
Files 63 63
Lines 9224 9231 +7
=======================================
+ Hits 9063 9070 +7
Misses 161 161 |
I think we were just lucky with #552, because now whatever I change around invoke I get 10% regression. The same story is in #574. |
chfast
force-pushed
the
call_optimization
branch
from
5c601fc
to
9eaffe6
Compare
|
Replaced by #602. The remaining code copy has no effect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results may be wrong as some benchmarks don't use calls.Confirmed for GCC10/LTO.