Pass arguments to host function as const Value* #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
host_funcs_args
branch
from
51e41db
to
1f6f4d0
Compare
Codecov Report
@@ Coverage Diff @@
## master #574 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 63 63
Lines 9254 9238 -16
=======================================
- Hits 9093 9078 -15
+ Misses 161 160 -1 |
chfast
force-pushed
the
host_funcs_args
branch
from
1f6f4d0
to
0d60aca
Compare
Closed
chfast
force-pushed
the
host_funcs_args
branch
from
0d60aca
to
626ac4a
Compare
|
|
The |
axic
reviewed
Oct 13, 2020
| @@ -486,7 +486,7 @@ inline bool invoke_function( | |||
| { | |||
| const auto num_args = func_type.inputs.size(); | |||
| assert(stack.size() >= num_args); | |||
| span<const Value> call_args{stack.rend() - num_args, num_args}; | |||
| const auto call_args = stack.rend() - num_args; | |||
There was a problem hiding this comment.
Didn't I do the same change in some PR already? Perhaps one of your old refactorings.
chfast
commented
Oct 13, 2020
lib/fizzy/capi.cpp
Outdated
| int depth) noexcept -> fizzy::ExecutionResult { | ||
| const auto result = func(context, wrap(&instance), wrap(args.data()), args.size(), depth); | ||
| const auto result = func(context, wrap(&instance), wrap(args), 0, depth); |
There was a problem hiding this comment.
This should be fixed, now or later.
gumb0
approved these changes
Oct 14, 2020
chfast
force-pushed
the
host_funcs_args
branch
from
02d85c1
to
cb1efa6
Compare
chfast
force-pushed
the
host_funcs_args
branch
from
cb1efa6
to
2a22c03
Compare
axic
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.