Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: add badges for crates.io #587

Merged
merged 1 commit into from
Oct 7, 2020
Merged

rust: add badges for crates.io #587

merged 1 commit into from
Oct 7, 2020

Conversation

axic
Copy link
Member

@axic axic commented Oct 6, 2020

No description provided.

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #587 into rust-doc will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           rust-doc     #587   +/-   ##
=========================================
  Coverage     98.23%   98.23%           
=========================================
  Files            62       62           
  Lines          9023     9023           
=========================================
  Hits           8864     8864           
  Misses          159      159           

@axic axic requested review from chfast and gumb0 October 6, 2020 17:54
@@ -15,3 +15,8 @@ edition = "2018"
[build-dependencies]
bindgen = "0.54.0"
cmake = "0.1"

[badges]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,5 @@
# Fizzy
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the readme which will be displayed on crates.io


[badges]
circle-ci = { repository = "https://github.com/wasmx/fizzy" }
codecov = { repository = "https://github.com/wasmx/fizzy" }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this should be:

Suggested change
codecov = { repository = "https://github.com/wasmx/fizzy" }
codecov = { repository = "wasmx/fizzy", service = "github" }

@@ -15,3 +15,8 @@ edition = "2018"
[build-dependencies]
bindgen = "0.54.0"
cmake = "0.1"

[badges]
circle-ci = { repository = "https://github.com/wasmx/fizzy" }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this should be:

Suggested change
circle-ci = { repository = "https://github.com/wasmx/fizzy" }
circle-ci = { repository = "wasmx/fizzy" }

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know either.

@axic axic changed the base branch from master to rust-doc October 7, 2020 11:00
@axic axic merged commit 3f58ffb into rust-doc Oct 7, 2020
@axic axic deleted the rust-badges branch October 7, 2020 12:23
@axic
Copy link
Member Author

axic commented Oct 7, 2020

Merged into #589 to make @chfast happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants