Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: add rustdoc descriptions to the public API and tiny improvements for crates.io #589

Merged
merged 4 commits into from
Oct 7, 2020

Conversation

axic
Copy link
Member

@axic axic commented Oct 6, 2020

No description provided.

@axic axic requested review from chfast and gumb0 October 6, 2020 20:03
@@ -0,0 +1,5 @@
# Fizzy
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what will be visible on crates.io

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@fcf0287). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #589   +/-   ##
=========================================
  Coverage          ?   98.23%           
=========================================
  Files             ?       62           
  Lines             ?     9023           
  Branches          ?        0           
=========================================
  Hits              ?     8864           
  Misses            ?      159           
  Partials          ?        0           

Copy link
Collaborator

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overlapped with #587

@axic
Copy link
Member Author

axic commented Oct 7, 2020

I know, I would merge this first.

@chfast
Copy link
Collaborator

chfast commented Oct 7, 2020

Please combine these 2 PRs to avoid the noise.

@axic
Copy link
Member Author

axic commented Oct 7, 2020

What noise?

@axic axic requested a review from chfast October 7, 2020 11:01
@axic axic changed the title rust: add rustdoc descriptions to the public API rust: add rustdoc descriptions to the public API and tiny improvements for crates.io Oct 7, 2020
@@ -2,10 +2,15 @@
// Copyright 2019-2020 The Fizzy Authors.
// SPDX-License-Identifier: Apache-2.0

//! This is a Rust interface to [Fizzy](https://github.com/wasmx/fizzy), a WebAssembly virtual machine.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between //! and ///?

Copy link
Member Author

@axic axic Oct 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//! is the description shown on the top of docs.rust.rs, while /// is the doxygen compatible description for syntactical elements. So basically //! stuff becomes the "README" for the documentation.

@axic axic merged commit e66e20d into master Oct 7, 2020
@axic axic deleted the rust-doc branch October 7, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants