Remove unnecessary dashboard queries (#5453)

* change ng-show to ng-if * Add verification that it is the welcome * Add changelog * Update changelog
wazuh · May 29, 2023 · 7d409b0 · 7d409b0
1 parent e4884fa
commit 7d409b0
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -42,6 +42,10 @@ All notable changes to the Wazuh app project will be documented in this file.
 
 - Removed deprecated request and code in agent's view [#5451](https://github.com/wazuh/wazuh-kibana-app/pull/5451)
 
+### Removed
+
+- Removed unnecessary dashboard queries caused by the deploy agent view. [#5453](https://github.com/wazuh/wazuh-kibana-app/pull/5453)
+
 ## Wazuh v4.4.3 - OpenSearch Dashboards 2.6.0 - Revision 01
 
 ### Added

diff --git a/public/controllers/agent/agents-preview.js b/public/controllers/agent/agents-preview.js
@@ -47,6 +47,7 @@ export class AgentsPreviewController {
     this.wazuhConfig = new WazuhConfig();
     this.errorInit = false;
     this.$window = $window;
+    this.addingNewAgent = false;
   }
 
   /**
@@ -100,9 +101,7 @@ export class AgentsPreviewController {
       updateSummary: (summary) => {
         this.summary = summary;
         if (this.summary.total === 0) {
-          if (this.addingNewAgent === undefined) {
-            this.addNewAgent(true);
-          }
+          this.addNewAgent(true);
           this.hasAgents = false;
         } else {
           this.hasAgents = true;

diff --git a/public/controllers/overview/overview.js b/public/controllers/overview/overview.js
@@ -197,7 +197,7 @@ export class OverviewController {
         }
       };
       setTimeout(() => { this.$location.search('agentId', store.getState().appStateReducers.currentAgentData.id ? String(store.getState().appStateReducers.currentAgentData.id) : null) }, 1);
-  
+
       this.visualizeProps["isAgent"] = agentList ? agentList[0] : false;
       this.$rootScope.$applyAsync();
     }catch(error){
@@ -283,7 +283,7 @@ export class OverviewController {
         timefilter.setRefreshInterval(this.commonData.getRefreshInterval());
       }
 
-      if (typeof this.agentsCount === 'undefined') {
+      if (typeof this.agentsCount === 'undefined' && newTab === 'welcome') {
         await this.getSummary();
       }
 

diff --git a/public/templates/visualize/dashboards.html b/public/templates/visualize/dashboards.html
@@ -1,8 +1,8 @@
 <div ng-controller="agentsPreviewController as actrl">
-  <div ng-init="actrl.addNewAgent(false)" ng-show="actrl.addingNewAgent">
+  <div ng-init="actrl.addNewAgent(false)" ng-if="actrl.addingNewAgent">
     <react-component name="RegisterAgent" props="actrl.registerAgentsProps"></react-component>
   </div>
-  <div ng-show="!actrl.addingNewAgent">
+  <div ng-if="!actrl.addingNewAgent">
     <div ng-controller="overviewController as octrl">
       <!-- Navigation section -->
       <div ng-show="octrl.tab && octrl.tab !== 'welcome'">