Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dashboard queries #5453

Merged
merged 6 commits into from
May 29, 2023
Merged

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented May 17, 2023

Description

Removed unnecessary requests in dashboard views

Issues Resolved

Evidence

Screenshot

Security events

image

FIM

image

Office 365

image

Amazon AWS

image

Google Cloud Plataform

image

GitHub

image

Policy monitoring

image

System auditing

image

OpenSCAP

image

CIS-CAT

image

VirusTotal

image

Osquery

image

Docker listener

image

MITRE ATT&CK

image

PCI DSS

image

GDPR

image

HIPAA

image

NIST

image

TSC

image

Deploy agent

image

Test

Verify that all dashboards continue to function as required and no request is made.

Verify that when you are going to deploy an agent, the necessary requests are made.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano requested a review from a team as a code owner May 17, 2023 12:53
@yenienserrano yenienserrano changed the title Remove unnecessary queries Removed unnecessary dashboard queries May 17, 2023
@yenienserrano yenienserrano changed the title Removed unnecessary dashboard queries Remove unnecessary dashboard queries May 17, 2023
@yenienserrano yenienserrano self-assigned this May 17, 2023
@yenienserrano yenienserrano requested a review from Desvelao May 29, 2023 09:19
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 9.46% ( 3506 / 37037 )
Branches 4.99% ( 1434 / 28702 )
Functions 8.13% ( 747 / 9179 )
Lines 9.54% ( 3386 / 35470 )

@Desvelao
Copy link
Member

Wazuh dashboard

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Verify that all dashboards continue to function as required and no request is made. 🟢
Verify that when you are going to deploy an agent, the necessary requests are made. 🟢

Details

🟢 Verify that all dashboards continue to function as required and no request is made.

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

🟢 Verify that when you are going to deploy an agent, the necessary requests are made.

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preview

code 🟢
test : 🟢 #5453 (comment)

@AlexRuiz7 AlexRuiz7 merged commit 7d409b0 into 4.5 May 29, 2023
@AlexRuiz7 AlexRuiz7 deleted the 5237-remove-unnecessary-queries branch May 29, 2023 12:26
@github-actions
Copy link
Contributor

The backport to 4.5-7.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.5-7.10 4.5-7.10
# Navigate to the new working tree
cd .worktrees/backport-4.5-7.10
# Create a new branch
git switch --create backport-5453-to-4.5-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7d409b0a8f72a7d2269492ddbe53f441e9a7bd28
# Push it to GitHub
git push --set-upstream origin backport-5453-to-4.5-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.5-7.10

Then, create a pull request where the base branch is 4.5-7.10 and the compare/head branch is backport-5453-to-4.5-7.10.

@github-actions
Copy link
Contributor

The backport to 4.5-7.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.5-7.16 4.5-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.5-7.16
# Create a new branch
git switch --create backport-5453-to-4.5-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7d409b0a8f72a7d2269492ddbe53f441e9a7bd28
# Push it to GitHub
git push --set-upstream origin backport-5453-to-4.5-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.5-7.16

Then, create a pull request where the base branch is 4.5-7.16 and the compare/head branch is backport-5453-to-4.5-7.16.

yenienserrano added a commit that referenced this pull request May 29, 2023
* change ng-show to ng-if

* Add verification that it is the welcome

* Add changelog

* Update changelog

(cherry picked from commit 7d409b0)
yenienserrano added a commit that referenced this pull request May 29, 2023
* change ng-show to ng-if

* Add verification that it is the welcome

* Add changelog

* Update changelog

(cherry picked from commit 7d409b0)
AlexRuiz7 added a commit that referenced this pull request May 29, 2023
Remove unnecessary dashboard queries (#5453)

* change ng-show to ng-if

* Add verification that it is the welcome

* Add changelog

* Update changelog

(cherry picked from commit 7d409b0)

Co-authored-by: Álex Ruiz <alejandro.ruiz.becerra@wazuh.com>
AlexRuiz7 added a commit that referenced this pull request May 29, 2023
Remove unnecessary dashboard queries (#5453)

* change ng-show to ng-if

* Add verification that it is the welcome

* Add changelog

* Update changelog

(cherry picked from commit 7d409b0)

Co-authored-by: Álex Ruiz <alejandro.ruiz.becerra@wazuh.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wazuh API usage - Unnecessary queries while accessing agent operations
3 participants