Add length validation to agent name #5028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asteriscos
previously approved these changes
Dec 22, 2022
Desvelao
reviewed
Dec 22, 2022
asteriscos
dismissed stale reviews from yenienserrano and themself
via
d3ac68f
Added a space between two pull request references.
asteriscos
approved these changes
Dec 22, 2022
yenienserrano
approved these changes
Dec 22, 2022
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add length validation to the agent name, in order to avoid entering incorrect names that may cause errors in different places of the app.
Issues Resolved
#4927
Evidence
Test
Scenario: have a Wazuh environment and navigate to agents/deploy new agent
When the users enter a name shorter than 2 characters
Then it should show an error telling that, and not show the deploy commands
Scenario: have a Wazuh environment and navigate to agents/deploy new agent
When the users doesn't enter any name
Then it should not show any errors and should show the deploy commands.
Check List
yarn test:jest