Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 4.4-2.4-wzd] Add length validation to agent name #5030

Merged
merged 5 commits into from
Dec 22, 2022
Merged

[Backport 4.4-2.4-wzd] Add length validation to agent name #5030

merged 5 commits into from
Dec 22, 2022

Conversation

Tostti
Copy link
Member

@Tostti Tostti commented Dec 21, 2022

Backport from #5028

@Tostti Tostti linked an issue Dec 21, 2022 that may be closed by this pull request
Validate the agent name field in the "Deploy a new agent" section #4927
Closed
@Tostti
Copy link
Member Author

Tostti commented Dec 21, 2022

Tested:
image
image
image

@Tostti Tostti marked this pull request as ready for review December 21, 2022 17:35
@Tostti Tostti requested a review from a team as a code owner December 21, 2022 17:35
Machi3mfl
Machi3mfl previously approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

Peek.2022-12-21.15-24.mp4

yenienserrano
yenienserrano previously approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asteriscos asteriscos dismissed stale reviews from yenienserrano and Machi3mfl via ec8679c December 22, 2022 14:26
@asteriscos
Update CHANGELOG.md
ec8679c 
Add space between two pull request references.
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.68% ( 3208 / 36931 )
Branches 4.63% ( 1330 / 28696 )
Functions 7.56% ( 692 / 9153 )
Lines 8.75% ( 3095 / 35365 )

@asteriscos asteriscos merged commit 3c16690 into 4.4-2.4-wzd Dec 22, 2022
@asteriscos asteriscos deleted the backport-5028-to-4.4-2.4-wzd branch December 22, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@asteriscos asteriscos asteriscos approved these changes

@Machi3mfl Machi3mfl Machi3mfl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate the agent name field in the "Deploy a new agent" section
4 participants
@Tostti @Machi3mfl @asteriscos @yenienserrano