Fix GitHub office365 panel information tab #5167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chantal-kelm
previously approved these changes
Jan 25, 2023
Tostti
previously approved these changes
Jan 25, 2023
Desvelao
reviewed
Jan 26, 2023
| @@ -22,8 +22,8 @@ export const ModuleSidePanel = ({ navIsDocked = false, children, ...props }) => | |||
| <EuiCollapsibleNav | |||
| isOpen={navIsOpen} | |||
| isDocked={navIsDocked} | |||
| showCloseButton={true} | |||
| maskProps={{ headerZindexLocation: 'below', className: 'wz-no-display' }} | |||
| ownFocus={false} | |||
There was a problem hiding this comment.
thought: I tested without this property definition, and add a mask under the component. It looks better visually. I checked in a previous version 4.3.10 and this doesn't have the mask, so I guess we could accept this change.
|
Desvelao
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
review
code 🟢
test 🟢
Wazuh dashboard
Legend:
⚫: none
🟢: passed
🔴: failed
🟡: warning
⚪: not applicable
UI
| Test | Chrome | Firefox | Safari |
|---|---|---|---|
| Open the info panel in the Panel tab of GitHub module | 🟢 | 🟢 | ⚫ |
| Open the info panel in the Panel tab of Office365 module | 🟢 | 🟢 | ⚫ |
Details
🟢 Open the info panel in the Panel tab of GitHub module
Chrome - 🟢
Firefox - 🟢
Safari - ⚫
🟢 Open the info panel in the Panel tab of Office365 module
Chrome - 🟢
Firefox - 🟢
Safari - ⚫
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi team,
This PR fixes GitHub office365 panel information tab by removing the euiCollapsibleNavbar custom styles and using newer eui v34.6.0 component properties to display the close button inside the container and to remove the overlay.
Important
This fix is for Opensearch 2.4.0 and above. Elasticsearch 7.10.x and 7.16.x branches don't require it.
Issues Resolved
Closes #5164
Evidence
Test
PaneltabiiconCheck List
yarn test:jest