Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub office365 panel information tab #5167

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Fix GitHub office365 panel information tab #5167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d230f2e
Remove overlay custom styles and close button
asteriscos Jan 25, 2023
f98ced8
Add changelog
asteriscos Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ All notable changes to the Wazuh app project will be documented in this file.
- Fixed mispelling in the NIST module [#5107](https://github.com/wazuh/wazuh-kibana-app/pull/5107)
- Fixed Statistic cronjob bulk document insert [#5150](https://github.com/wazuh/wazuh-kibana-app/pull/5150)
- Fixed the style of the buttons showing more event information in the event view table. [#5137](https://github.com/wazuh/wazuh-kibana-app/pull/5137)
- Fixed the module information button in Office365 and Github Panel tab to open the nav drawer. [#5167](https://github.com/wazuh/wazuh-kibana-app/pull/5167)

### Removed

Expand Down
9 changes: 2 additions & 7 deletions public/components/common/modules/panel/components/module-side-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ export const ModuleSidePanel = ({ navIsDocked = false, children, ...props }) =>
<EuiCollapsibleNav
isOpen={navIsOpen}
isDocked={navIsDocked}
showCloseButton={true}
maskProps={{ headerZindexLocation: 'below', className: 'wz-no-display' }}
ownFocus={false}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: I tested without this property definition, and add a mask under the component. It looks better visually. I checked in a previous version 4.3.10 and this doesn't have the mask, so I guess we could accept this change.

closeButtonPosition={'inside'}
button={
<EuiButtonEmpty
className={'sidepanel-infoBtnStyle'}
Expand All @@ -34,11 +34,6 @@ export const ModuleSidePanel = ({ navIsDocked = false, children, ...props }) =>
onClose={() => setNavIsOpen(false)}
>
<div>
<EuiButtonEmpty
style={{ position: 'absolute', right: 0 }}
onClick={() => setNavIsOpen(!navIsOpen)}
iconType={'cross'}
/>
<div className={'wz-padding-16'}>{children}</div>
</div>
</EuiCollapsibleNav>
Expand Down